Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(70)

Issue 125530043: Build the tools and libraries all at once with Maven. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by roubert (google)
Modified:
10 years, 2 months ago
Reviewers:
lararennie, Shaopeng
CC:
daniel2
Base URL:
https://libphonenumber.googlecode.com/svn/trunk
Visibility:
Public.

Description

Build the tools and libraries all at once with Maven. This patch adds a top level pom.xml so it is now possible to checkout the repository and do mvn clean install and it will build the tools JAR and then the library itself without requiring any pre-built JARs in the repository I've also tweaked the Debian packaging to work using maven-debian-helper and without using Ant or build.xml any more. I'll submit that as a separate patch. The patch also removes a reference to oss-parent that appears to be in java/pom.xml by mistake, this was causing the maven-debian-helper builds to fail. Author: daniel@pocock.pro R=jia.shao.peng@gmail.com BUG= Committed: https://code.google.com/p/libphonenumber/source/detail?r=687

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
M java/pom.xml View 1 chunk +0 lines, -6 lines 0 comments Download
A + pom.xml View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 3
roubert (google)
10 years, 2 months ago (2014-08-19 20:44:28 UTC) #1
Shaopeng
On 2014/08/19 20:44:28, roubert (google) wrote: LGTM
10 years, 2 months ago (2014-08-22 14:41:28 UTC) #2
roubert (google)
10 years, 2 months ago (2014-08-22 14:43:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 687 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b