Issue 125530043: Build the tools and libraries all at once with Maven.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 125530043: Build the tools and libraries all at once with Maven. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by roubert (google)

Modified:
10 years, 3 months ago

Reviewers:
lararennie, Shaopeng

CC:
daniel2

Base URL:
https://libphonenumber.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Build the tools and libraries all at once with Maven. This patch adds a top level pom.xml so it is now possible to checkout the repository and do mvn clean install and it will build the tools JAR and then the library itself without requiring any pre-built JARs in the repository I've also tweaked the Debian packaging to work using maven-debian-helper and without using Ant or build.xml any more. I'll submit that as a separate patch. The patch also removes a reference to oss-parent that appears to be in java/pom.xml by mistake, this was causing the maven-debian-helper builds to fail. Author: daniel@pocock.pro R=jia.shao.peng@gmail.com BUG= Committed: https://code.google.com/p/libphonenumber/source/detail?r=687

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -12 lines)			Patch
	M	java/pom.xml	View		1 chunk	+0 lines, -6 lines	0 comments	Download
	A +	pom.xml	View		2 chunks	+3 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

roubert (google)

10 years, 3 months ago (2014-08-22 14:43:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 687 (presubmit successful).

Expand All Messages | Collapse All Messages