http: clear out clirr-ignored-differences

http: clear out clirr-ignored-differences

[ngmiceli, 2013-08-09 14:15:21]

https://codereview.appspot.com/12545045/diff/5001/clirr-ignored-differences.xml
File clirr-ignored-differences.xml (left):

https://codereview.appspot.com/12545045/diff/5001/clirr-ignored-differences.x...
clirr-ignored-differences.xml:17:
<className>com/google/api/client/repackaged/**</className>
I don't believe we need this anymore either. This shouldn't be a change vs 1.16

[yanivi, 2013-08-09 14:50:57]

https://codereview.appspot.com/12545045/diff/5001/clirr-ignored-differences.xml
File clirr-ignored-differences.xml (left):

https://codereview.appspot.com/12545045/diff/5001/clirr-ignored-differences.x...
clirr-ignored-differences.xml:17:
<className>com/google/api/client/repackaged/**</className>
On 2013/08/09 14:15:21, ngmiceli wrote:
> I don't believe we need this anymore either. This shouldn't be a change vs
1.16

It is needed.  For whatever reason it compares against the non-repackaged jar of
default, so it thinks they were removed.  Maybe there is a way to get it to
compare it properly but I haven't bothered, since this ignore seems to be
sufficient.

[ngmiceli, 2013-08-12 16:56:55]

mvn clirr:check succeeds for me with a fully-empty clirr-ignored-differences
file. Does it not for you?

[yanivi, 2013-08-12 17:02:07]

mvn -q clirr:check

[ERROR] com.google.api.client.repackaged.com.google.common.annotations.Beta:
Class com.google.api.client.repackaged.com.google.common.annotations.Beta
removed
[ERROR]
com.google.api.client.repackaged.com.google.common.annotations.GwtCompatible:
Class
com.google.api.client.repackaged.com.google.common.annotations.GwtCompatible
removed
[ERROR]
com.google.api.client.repackaged.com.google.common.annotations.VisibleForTesting:
Class
com.google.api.client.repackaged.com.google.common.annotations.VisibleForTesting
removed
[ERROR] com.google.api.client.repackaged.com.google.common.base.Joiner: Class
com.google.api.client.repackaged.com.google.common.base.Joiner removed
[ERROR]
com.google.api.client.repackaged.com.google.common.base.Joiner$MapJoiner: Class
com.google.api.client.repackaged.com.google.common.base.Joiner$MapJoiner removed
[ERROR] com.google.api.client.repackaged.com.google.common.base.Objects: Class
com.google.api.client.repackaged.com.google.common.base.Objects removed
[ERROR]
com.google.api.client.repackaged.com.google.common.base.Objects$ToStringHelper:
Class
com.google.api.client.repackaged.com.google.common.base.Objects$ToStringHelper
removed
[ERROR] com.google.api.client.repackaged.com.google.common.base.Preconditions:
Class com.google.api.client.repackaged.com.google.common.base.Preconditions
removed
[ERROR] com.google.api.client.repackaged.com.google.common.base.Strings: Class
com.google.api.client.repackaged.com.google.common.base.Strings removed
[ERROR] com.google.api.client.repackaged.com.google.common.base.Throwables:
Class com.google.api.client.repackaged.com.google.common.base.Throwables removed
[ERROR] com.google.api.client.repackaged.org.apache.commons.codec.BinaryDecoder:
Class com.google.api.client.repackaged.org.apache.commons.codec.BinaryDecoder
removed
[ERROR] com.google.api.client.repackaged.org.apache.commons.codec.BinaryEncoder:
Class com.google.api.client.repackaged.org.apache.commons.codec.BinaryEncoder
removed
[ERROR] com.google.api.client.repackaged.org.apache.commons.codec.Decoder: Class
com.google.api.client.repackaged.org.apache.commons.codec.Decoder removed
[ERROR]
com.google.api.client.repackaged.org.apache.commons.codec.DecoderException:
Class com.google.api.client.repackaged.org.apache.commons.codec.DecoderException
removed
[ERROR] com.google.api.client.repackaged.org.apache.commons.codec.Encoder: Class
com.google.api.client.repackaged.org.apache.commons.codec.Encoder removed
[ERROR]
com.google.api.client.repackaged.org.apache.commons.codec.EncoderException:
Class com.google.api.client.repackaged.org.apache.commons.codec.EncoderException
removed
[ERROR] com.google.api.client.repackaged.org.apache.commons.codec.binary.Base64:
Class com.google.api.client.repackaged.org.apache.commons.codec.binary.Base64
removed
[ERROR]
com.google.api.client.repackaged.org.apache.commons.codec.binary.BaseNCodec:
Class
com.google.api.client.repackaged.org.apache.commons.codec.binary.BaseNCodec
removed
[ERROR]
com.google.api.client.repackaged.org.apache.commons.codec.binary.StringUtils:
Class
com.google.api.client.repackaged.org.apache.commons.codec.binary.StringUtils
removed

[ngmiceli, 2013-08-12 17:07:48]

LGTM