Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(642)

Issue 125360044: Make lgtm detection have fewer false positives (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by jrobbins (chromium)
Modified:
11 years ago
CC:
codereview-list_googlegroups.com
Visibility:
Public.

Description

Look for "lgtm" only as a whole word, so that it will not match occurances of those letters used as part of filenames or variable names in code. I did this on the chromium branch, but I intend to commit it to the default branch too. BUG=352637

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M codereview/models.py View 3 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 3
jrobbins (corp)
PTAL. This responds to the topic of your email thread where a variable name was ...
11 years ago (2014-08-15 19:52:27 UTC) #1
phajdan.jr
LGTM
11 years ago (2014-08-19 10:56:45 UTC) #2
jrobbins (corp)
11 years ago (2014-08-20 20:38:24 UTC) #3

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b