Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3)

Issue 12523045: Fix Proxy invariant violations checked by Chrome. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by kpreid_google
Modified:
12 years, 8 months ago
Reviewers:
MarkM, ihab.awad
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

* Both SES and ES5/3 proxy-based ArrayLikes now correctly report .length as configurable. * <form> elements no longer return a list of property names containing 'length' twice. * Added toString methods to proxy handlers in ES5/3. (Unfortunately, they did not help in tracking down this bug due to <https://code.google.com/p/v8/issues/detail?id=2832>.) Fixes <https://code.google.com/p/google-caja/issues/detail?id=1696>. @r5538

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix Proxy invariant violations checked by Chrome. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -6 lines) Patch
M src/com/google/caja/es53.js View 4 chunks +8 lines, -2 lines 0 comments Download
M src/com/google/caja/plugin/domado.js View 1 1 chunk +5 lines, -2 lines 0 comments Download
M src/com/google/caja/ses/startSES.js View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 5
kpreid_google
12 years, 8 months ago (2013-08-07 21:39:58 UTC) #1
ihab.awad
lgtm https://codereview.appspot.com/12523045/diff/1/src/com/google/caja/plugin/domado.js File src/com/google/caja/plugin/domado.js (right): https://codereview.appspot.com/12523045/diff/1/src/com/google/caja/plugin/domado.js#newcode5343 src/com/google/caja/plugin/domado.js:5343: // here it would be a duplicate. ...
12 years, 8 months ago (2013-08-07 21:46:53 UTC) #2
kpreid_google
* Both SES and ES5/3 proxy-based ArrayLikes now correctly report .length as configurable. * <form> ...
12 years, 8 months ago (2013-08-07 21:48:17 UTC) #3
kpreid_google
https://codereview.appspot.com/12523045/diff/1/src/com/google/caja/plugin/domado.js File src/com/google/caja/plugin/domado.js (right): https://codereview.appspot.com/12523045/diff/1/src/com/google/caja/plugin/domado.js#newcode5343 src/com/google/caja/plugin/domado.js:5343: // here it would be a duplicate. On 2013/08/07 ...
12 years, 8 months ago (2013-08-07 21:48:21 UTC) #4
MarkM
12 years, 8 months ago (2013-08-07 22:35:48 UTC) #5
ses/* parts LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b