Obtain Azure simplestreams endpoint from gwacl.

Obtain Azure simplestreams endpoint from gwacl.

This matches an incompatible API change in gwacl r213.  It asks gwacl for the right API endpoint to pass to simplestreams (China has a different one to the rest of the world) and removes the old hard-coded URL.

I also discovered to my embarrassment that getEndpoint was implemented twice: once as a method and once as a stand-alone function.  The latter is all that's needed, and there's not much reason for the former.  The tests turned out much simpler than originally envisaged.

https://code.launchpad.net/~jtv/juju-core/az-endpoint/+merge/178686

(do not edit description out of merge proposal)

[jtv.canonical, 2013-08-06 08:22:20]

Please take a look.

[dimitern, 2013-08-06 08:54:13]

LGTM with one question.

https://codereview.appspot.com/12512043/diff/1/environs/azure/instancetype_te...
File environs/azure/instancetype_test.go (right):

https://codereview.appspot.com/12512043/diff/1/environs/azure/instancetype_te...
environs/azure/instancetype_test.go:282: c.Check(

Why Check and not Assert here?

[rog, 2013-08-06 08:57:43]

LGTM with one thought below.

https://codereview.appspot.com/12512043/diff/1/environs/azure/instancetype.go
File environs/azure/instancetype.go (right):

https://codereview.appspot.com/12512043/diff/1/environs/azure/instancetype.go...
environs/azure/instancetype.go:113: func getEndpoint(location string) string {
Given that gwacl has a GetEndpoint function that
returns something slightly different, I think
this function is somewhat misleading - I'd
just inline it into findMatchingImages.

https://codereview.appspot.com/12512043/diff/1/environs/azure/instancetype_te...
File environs/azure/instancetype_test.go (right):

https://codereview.appspot.com/12512043/diff/1/environs/azure/instancetype_te...
environs/azure/instancetype_test.go:282: c.Check(
On 2013/08/06 08:54:14, dimitern wrote:
> 
> Why Check and not Assert here?

Why not?
I think it's good to use Check whereever a failed
check doesn't compromise the ability to continue
with the test in a sane way.

[jtvjtv, 2013-08-06 09:48:08]

Thanks chaps!  My answer to that question was exactly what rog said.  :-)