Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1)

Issue 12509: Issue 955: Parity error: Unowned property (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
17 years, 2 months ago by MikeSamuel
Modified:
16 years, 8 months ago
Reviewers:
MarkM
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

In testbed.js: if (!name && ('name' in ctor) && !___.hasOwnProp(ctor, 'name')) { name = ctor.name; } appears in a context where ctor is a genuine constructor function. This will only be true when Function.prototype has a 'name' property (as it does at least on FF, where it is the empty string) and ctor does not override it with its own 'name' property. I suspect you meant not to "!" the hasOwnProp test.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/com/google/caja/opensocial/applet/testbed.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
MikeSamuel
17 years, 2 months ago (2009-01-26 07:19:18 UTC) #1
MarkM
Yup. LGTM
17 years, 2 months ago (2009-01-26 16:42:03 UTC) #2
MikeSamuel
17 years, 2 months ago (2009-01-26 18:27:09 UTC) #3
@3202
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b