Issue 125053: fix browser-expectations

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 125053: fix browser-expectations (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 8 months ago by felix8a

Modified:
16 years, 8 months ago

Reviewers:
MikeSamuel

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

1. one of the tests wants popup blockers to be disabled, and tries to tell you that. on safari, when window.open is blocked, it returns undefined instead of null, so the test was failing without a useful diagnostic. 2. at the moment, the test summary in the title relies on explicit calls to jsunit.pass(). two tests were missing that call, so a successful result was "0/11 fail, 9/11 pass".

Patch Set 1 #

Created: 16 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -5 lines)			Patch
	M	tests/com/google/caja/browser-expectations.html	View		3 chunks	+11 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

On 2009/09/28 05:11:45, MikeSamuel wrote:
> LGTM

@r3763

Expand All Messages | Collapse All Messages