Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(32)

Issue 125048: Bug 940: Access to FileSystemEnvironment (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 8 months ago by MikeSamuel
Modified:
16 years, 8 months ago
Reviewers:
metaweta, plus.ajg
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

From http://code.google.com/p/google-caja/issues/detail?id=940 While the class FileSystemEnvironment is public, its only constructor isn't, which means there's currently no way to derive from it outside of the caja.plugin package. Is this by design? It's a useful base class and it'd be nice to be able to take advantage of it. Similarly, it'd be pretty useful if PluginCompilerMain's private CachingEnvironment were factored out into an independent public class. Submitted @3758

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/com/google/caja/plugin/FileSystemEnvironment.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
MikeSamuel
16 years, 8 months ago (2009-09-26 03:50:24 UTC) #1
metaweta
16 years, 8 months ago (2009-09-26 17:21:22 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b