Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(40)

Issue 125045: Make upload.py use --no-renames. This generates more SVN-like patches,

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 3 months ago by nickcarter
Modified:
16 years, 3 months ago
Reviewers:
evan, evanm
CC:
evanm
Visibility:
Public.

Description

Make upload.py use --no-renames. This generates more SVN-like patches, ones that are broken down into add+delete operations. The result will be reviews that are more consistent with what gcl produces on svn. Also, fix the 'git show' command for renames (renames shouldn't happen with --no-renames) where there is no corresponding edit in the diff. Previously this would crash.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M upload.py View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3
nickcarter
To see what renames look like in Rietveld before and after this change, see the ...
16 years, 3 months ago (2009-09-25 22:58:04 UTC) #1
nickcarter
Actually, I realized that --no-renames means that we lose history, particularly in the edit case. ...
16 years, 3 months ago (2009-09-25 23:01:21 UTC) #2
evan
16 years, 3 months ago (2009-09-25 23:19:49 UTC) #3
Since this file is in Rietveld, you'll need to make the patch against Rietveld
(static/upload.py in their tree).  I can review+commit your patches on that.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b