Expose varying variables and also precision for all variables.

Expose varying variables and also precision for all variables.

ANGLEBUG=457
R=alokp@chromium.org, kbr@chromium.org

Committed: https://code.google.com/p/angleproject/source/detail?r=76985f3

[Zhenyao Mo, 2013-08-05 22:58:27]

kbr, alokp, nicolas: please take a look.

shannon: will you be taking care of merging to ES3 branch? Does this one look OK
to merge?

[kbr1, 2013-08-07 03:24:25]

https://codereview.appspot.com/12487043/diff/1/include/GLSLANG/ShaderLang.h
File include/GLSLANG/ShaderLang.h (right):

https://codereview.appspot.com/12487043/diff/1/include/GLSLANG/ShaderLang.h#n...
include/GLSLANG/ShaderLang.h:342: COMPILER_EXPORT void ShGetInfo(const ShHandle
handle,
This API needs to be expanded to allow querying of the number of varyings in the
shader.

[Zhenyao Mo, 2013-08-07 17:27:59]

https://codereview.appspot.com/12487043/diff/1/include/GLSLANG/ShaderLang.h
File include/GLSLANG/ShaderLang.h (right):

https://codereview.appspot.com/12487043/diff/1/include/GLSLANG/ShaderLang.h#n...
include/GLSLANG/ShaderLang.h:342: COMPILER_EXPORT void ShGetInfo(const ShHandle
handle,
On 2013/08/07 03:24:25, kbr1 wrote:
> This API needs to be expanded to allow querying of the number of varyings in
the
> shader.

It is.  The added SH_VARYINGS enum is the pname for this query.

[Shannon Woods, 2013-08-07 19:53:08]

On 2013/08/05 22:58:27, Zhenyao Mo wrote:
> kbr, alokp, nicolas: please take a look.
> 
> shannon: will you be taking care of merging to ES3 branch? Does this one look
OK
> to merge?

This CL looks fairly straightforward to merge.

[Alok Priyadarshi, 2013-08-09 18:44:37]

lgtm with minor nits.

https://codereview.appspot.com/12487043/diff/1/include/GLSLANG/ShaderLang.h
File include/GLSLANG/ShaderLang.h (right):

https://codereview.appspot.com/12487043/diff/1/include/GLSLANG/ShaderLang.h#n...
include/GLSLANG/ShaderLang.h:370: //               SH_ACTIVE_ATTRIBUTES,
SH_ACTIVE_UNIFORMS, SH_VARYING.
SH_VARYING -> SH_VARYINGS

https://codereview.appspot.com/12487043/diff/1/include/GLSLANG/ShaderLang.h#n...
include/GLSLANG/ShaderLang.h:390: ShShaderInfo varibaleType,
typo: varibale -> variable

https://codereview.appspot.com/12487043/diff/1/src/compiler/ShaderLang.cpp
File src/compiler/ShaderLang.cpp (right):

https://codereview.appspot.com/12487043/diff/1/src/compiler/ShaderLang.cpp#ne...
src/compiler/ShaderLang.cpp:24: static bool checkVariableMaxLengths(const
ShHandle handle,
please format

[kbr1, 2013-08-13 01:31:32]

LGTM with documentation updates. Please go through all of ShaderLang.h and make
sure there aren't other stray references to the old enums or APIs.

https://codereview.appspot.com/12487043/diff/1/include/GLSLANG/ShaderLang.h
File include/GLSLANG/ShaderLang.h (right):

https://codereview.appspot.com/12487043/diff/1/include/GLSLANG/ShaderLang.h#n...
include/GLSLANG/ShaderLang.h:305: // SH_ATTRIBUTES_UNIFORMS: Extracts attributes
and uniforms.
This documentation must be updated to refer to SH_VARYINGS and
ShGetVariableInfo.

https://codereview.appspot.com/12487043/diff/1/include/GLSLANG/ShaderLang.h#n...
include/GLSLANG/ShaderLang.h:342: COMPILER_EXPORT void ShGetInfo(const ShHandle
handle,
On 2013/08/07 17:27:59, Zhenyao Mo wrote:
> On 2013/08/07 03:24:25, kbr1 wrote:
> > This API needs to be expanded to allow querying of the number of varyings in
> the
> > shader.
> 
> It is.  The added SH_VARYINGS enum is the pname for this query.

Then the documentation must be updated to indicate that SH_VARYINGS is a valid
argument, and what querying it returns.

[Zhenyao Mo, 2013-08-14 17:54:14]

https://codereview.appspot.com/12487043/diff/1/include/GLSLANG/ShaderLang.h
File include/GLSLANG/ShaderLang.h (right):

https://codereview.appspot.com/12487043/diff/1/include/GLSLANG/ShaderLang.h#n...
include/GLSLANG/ShaderLang.h:305: // SH_ATTRIBUTES_UNIFORMS: Extracts attributes
and uniforms.
On 2013/08/13 01:31:32, kbr1 wrote:
> This documentation must be updated to refer to SH_VARYINGS and
> ShGetVariableInfo.

Done.

https://codereview.appspot.com/12487043/diff/1/include/GLSLANG/ShaderLang.h#n...
include/GLSLANG/ShaderLang.h:342: COMPILER_EXPORT void ShGetInfo(const ShHandle
handle,
On 2013/08/13 01:31:32, kbr1 wrote:
> On 2013/08/07 17:27:59, Zhenyao Mo wrote:
> > On 2013/08/07 03:24:25, kbr1 wrote:
> > > This API needs to be expanded to allow querying of the number of varyings
in
> > the
> > > shader.
> > 
> > It is.  The added SH_VARYINGS enum is the pname for this query.
> 
> Then the documentation must be updated to indicate that SH_VARYINGS is a valid
> argument, and what querying it returns.

Done.

https://codereview.appspot.com/12487043/diff/1/include/GLSLANG/ShaderLang.h#n...
include/GLSLANG/ShaderLang.h:370: //               SH_ACTIVE_ATTRIBUTES,
SH_ACTIVE_UNIFORMS, SH_VARYING.
On 2013/08/09 18:44:37, Alok Priyadarshi wrote:
> SH_VARYING -> SH_VARYINGS

Done.

https://codereview.appspot.com/12487043/diff/1/include/GLSLANG/ShaderLang.h#n...
include/GLSLANG/ShaderLang.h:390: ShShaderInfo varibaleType,
On 2013/08/09 18:44:37, Alok Priyadarshi wrote:
> typo: varibale -> variable

Done.

https://codereview.appspot.com/12487043/diff/1/src/compiler/ShaderLang.cpp
File src/compiler/ShaderLang.cpp (right):

https://codereview.appspot.com/12487043/diff/1/src/compiler/ShaderLang.cpp#ne...
src/compiler/ShaderLang.cpp:24: static bool checkVariableMaxLengths(const
ShHandle handle,
On 2013/08/09 18:44:37, Alok Priyadarshi wrote:
> please format

Done.

[Zhenyao Mo, 2013-08-14 20:37:35]

Committed patchset #7 manually as r67a7a71 (presubmit successful).

[Zhenyao Mo, 2013-08-14 20:52:33]

Committed patchset #8 manually as r6553766 (presubmit successful).

[Zhenyao Mo, 2013-08-14 21:36:16]

Committed patchset #8 manually as r76985f3 (presubmit successful).