Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(345)

Unified Diff: src/pkg/go/build/build.go

Issue 12485044: code review 12485044: undo CL 12486043 / ab644299d124 (Closed)
Patch Set: diff -r ab644299d124 https://go.googlecode.com/hg/ Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/pkg/encoding/xml/xml.go ('k') | src/pkg/go/printer/printer.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/pkg/go/build/build.go
===================================================================
--- a/src/pkg/go/build/build.go
+++ b/src/pkg/go/build/build.go
@@ -877,7 +877,7 @@
// Split at colon.
line = strings.TrimSpace(line[4:])
- i := strings.IndexByte(line, ':')
+ i := strings.Index(line, ":")
if i < 0 {
return fmt.Errorf("%s: invalid #cgo line: %s", filename, orig)
}
@@ -1022,7 +1022,7 @@
if name == "" {
return false
}
- if i := strings.IndexByte(name, ','); i >= 0 {
+ if i := strings.Index(name, ","); i >= 0 {
// comma-separated list
return ctxt.match(name[:i]) && ctxt.match(name[i+1:])
}
@@ -1076,7 +1076,7 @@
// name_$(GOOS)_$(GOARCH)_test.*
//
func (ctxt *Context) goodOSArchFile(name string) bool {
- if dot := strings.IndexByte(name, '.'); dot != -1 {
+ if dot := strings.Index(name, "."); dot != -1 {
name = name[:dot]
}
l := strings.Split(name, "_")
« no previous file with comments | « src/pkg/encoding/xml/xml.go ('k') | src/pkg/go/printer/printer.go » ('j') | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b