Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(489)

Unified Diff: src/pkg/reflect/all_test.go

Issue 12485043: code review 12485043: reflect: Get rid of the test for the error message when (Closed)
Patch Set: diff -r 816f25454af2 https://khr%40golang.org@code.google.com/p/go/ Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/pkg/reflect/all_test.go
===================================================================
--- a/src/pkg/reflect/all_test.go
+++ b/src/pkg/reflect/all_test.go
@@ -3509,14 +3509,3 @@
func (x *exhaustive) Maybe() bool {
return x.Choose(2) == 1
}
-
-func bigArgFunc(v [(1<<30)+64]byte) {
-}
-
-func TestBigArgs(t *testing.T) {
- if !testing.Short() && ^uint(0)>>32 != 0 { // test on 64-bit only
- v := new([(1<<30)+64]byte)
- bigArgFunc(*v) // regular calls are ok
- shouldPanic(func() {ValueOf(bigArgFunc).Call([]Value{ValueOf(*v)})}) // ... just not reflect calls
- }
-}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b