src/pkg/syscall/zerrors_freebsd_386.go - Issue 12476043: code review 12476043: net: use F_DUPFD_CLOEXEC when duping fds

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: src/pkg/syscall/zerrors_freebsd_386.go

Issue 12476043: code review 12476043: net: use F_DUPFD_CLOEXEC when duping fds (Closed)

Left Patch Set: diff -r ffe930a195f4 https://go.googlecode.com/hg/ Created 11 years, 7 months ago

Right Patch Set: diff -r 58c839988402 https://go.googlecode.com/hg/ Created 11 years, 7 months ago

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Right: Side by side diff | Download

LEFT	RIGHT
(no file at all)
1 // mkerrors.sh -m32	1 // mkerrors.sh -m32

2 // MACHINE GENERATED BY THE COMMAND ABOVE; DO NOT EDIT	2 // MACHINE GENERATED BY THE COMMAND ABOVE; DO NOT EDIT

3	3

4 // Created by cgo -godefs - DO NOT EDIT	4 // Created by cgo -godefs - DO NOT EDIT

5 // cgo -godefs -- -m32 _const.go	5 // cgo -godefs -- -m32 _const.go

6	6

7 package syscall	7 package syscall

8	8

9 const (	9 const (

10 AF_APPLETALK = 0x10	10 AF_APPLETALK = 0x10

(...skipping 420 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
431 EV_RECEIPT = 0x40	431 EV_RECEIPT = 0x40

432 EV_SYSFLAGS = 0xf000	432 EV_SYSFLAGS = 0xf000

433 EXTA = 0x4b00	433 EXTA = 0x4b00

434 EXTB = 0x9600	434 EXTB = 0x9600

435 EXTPROC = 0x800	435 EXTPROC = 0x800

436 FD_CLOEXEC = 0x1	436 FD_CLOEXEC = 0x1

437 FD_SETSIZE = 0x400	437 FD_SETSIZE = 0x400

438 FLUSHO = 0x800000	438 FLUSHO = 0x800000

439 F_CANCEL = 0x5	439 F_CANCEL = 0x5

440 F_DUP2FD = 0xa	440 F_DUP2FD = 0xa

	441 F_DUP2FD_CLOEXEC = 0x12

441 F_DUPFD = 0x0	442 F_DUPFD = 0x0

	443 F_DUPFD_CLOEXEC = 0x11

442 F_GETFD = 0x1	444 F_GETFD = 0x1

443 F_GETFL = 0x3	445 F_GETFL = 0x3

444 F_GETLK = 0xb	446 F_GETLK = 0xb

445 F_GETOWN = 0x5	447 F_GETOWN = 0x5

446 F_OGETLK = 0x7	448 F_OGETLK = 0x7

447 F_OK = 0x0	449 F_OK = 0x0

448 F_OSETLK = 0x8	450 F_OSETLK = 0x8

449 F_OSETLKW = 0x9	451 F_OSETLKW = 0x9

450 F_RDAHEAD = 0x10	452 F_RDAHEAD = 0x10

451 F_RDLCK = 0x1	453 F_RDLCK = 0x1

(...skipping 1225 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1677 24: "cputime limit exceeded",	1679 24: "cputime limit exceeded",

1678 25: "filesize limit exceeded",	1680 25: "filesize limit exceeded",

1679 26: "virtual timer expired",	1681 26: "virtual timer expired",

1680 27: "profiling timer expired",	1682 27: "profiling timer expired",

1681 28: "window size changes",	1683 28: "window size changes",

1682 29: "information request",	1684 29: "information request",

1683 30: "user defined signal 1",	1685 30: "user defined signal 1",

1684 31: "user defined signal 2",	1686 31: "user defined signal 2",

1685 32: "unknown signal",	1687 32: "unknown signal",

1686 }	1688 }

LEFT	RIGHT