Add a new flag to use ctmalloc in BlockHeapManager.

Add a new flag to use ctmalloc in BlockHeapManager.

This feature isn't supported yet, but I plan to plug it soon and then we'll have a flag to control it.

BUG=
R=chrisha@chromium.org

Committed: https://code.google.com/p/sawbuck/source/detail?r=2261

[Sébastien Marchand, 2014-08-18 21:00:37]

PTAL.

[chrisha, 2014-08-18 21:05:04]

https://codereview.appspot.com/124550044/diff/1/syzygy/common/asan_parameters.h
File syzygy/common/asan_parameters.h (right):

https://codereview.appspot.com/124550044/diff/1/syzygy/common/asan_parameters...
syzygy/common/asan_parameters.h:99: // BlockHeapManager: Indicates if CTMalloc
should be used to serve the
CtMallocHeap is what the class is called, so s/CTMalloc/CtMalloc/ here and
everywhere.

https://codereview.appspot.com/124550044/diff/1/syzygy/common/asan_parameters...
syzygy/common/asan_parameters.h:103: unsigned use_ctmalloc : 1;
enable_ctmalloc instead of use_ctmalloc? That way when we flip the default we'll
be able to call it disable_ctmalloc?

[Sébastien Marchand, 2014-08-18 21:22:26]

Thanks, PTAnL.

https://codereview.appspot.com/124550044/diff/1/syzygy/common/asan_parameters.h
File syzygy/common/asan_parameters.h (right):

https://codereview.appspot.com/124550044/diff/1/syzygy/common/asan_parameters...
syzygy/common/asan_parameters.h:99: // BlockHeapManager: Indicates if CTMalloc
should be used to serve the
On 2014/08/18 21:05:04, chrisha wrote:
> CtMallocHeap is what the class is called, so s/CTMalloc/CtMalloc/ here and
> everywhere.

Done.

https://codereview.appspot.com/124550044/diff/1/syzygy/common/asan_parameters...
syzygy/common/asan_parameters.h:103: unsigned use_ctmalloc : 1;
On 2014/08/18 21:05:04, chrisha wrote:
> enable_ctmalloc instead of use_ctmalloc? That way when we flip the default
we'll
> be able to call it disable_ctmalloc?

Done.

[chrisha, 2014-08-18 21:29:47]

lgtm!

[Sébastien Marchand, 2014-08-18 21:34:04]

Thanks, committing.

[Sébastien Marchand, 2014-08-18 23:08:17]

Committed patchset #2 manually as 2261 (presubmit successful).