Issue 1245044: Lazy allocation of MutableContent#pipelinedData

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1245044: Lazy allocation of MutableContent#pipelinedData (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 11 months ago by janluehe

Modified:
15 years, 9 months ago

Reviewers:
johnfargo, shindig.remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

This change has MutableContent allocate its "pipelinedData" field (of type java.util.Map) only if needed. This fixes https://issues.apache.org/jira/browse/SHINDIG-1336

Patch Set 2 : Updated patch, based on johnfargo's comment #

Created: 15 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
		java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/MutableContent.java	View	1	5 chunks	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

johnfargo

http://codereview.appspot.com/1245044/diff/1/3 File java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/MutableContent.java (right): http://codereview.appspot.com/1245044/diff/1/3#newcode229 java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/MutableContent.java:229: return pipelinedData; to avoid mandating that clients to null-checks, ...

15 years, 11 months ago (2010-05-20 23:24:55 UTC) #2

johnfargo

15 years, 11 months ago (2010-05-21 18:44:35 UTC) #4

Thanks! Committed.

On 2010/05/20 23:52:36, janluehe wrote:
> Updated patch, based on johnfargo's comment

Expand All Messages | Collapse All Messages