src/pkg/runtime/pprof/pprof.go - Issue 12429045: code review 12429045: runtime/pprof: test multithreaded profile, remove OS X ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/runtime/pprof/pprof.go

Issue 12429045: code review 12429045: runtime/pprof: test multithreaded profile, remove OS X ... (Closed)

Patch Set: diff -r 1bac09ef43f0 https://code.google.com/p/go/ Created 11 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/runtime/pprof/pprof.go

===================================================================

--- a/src/pkg/runtime/pprof/pprof.go

+++ b/src/pkg/runtime/pprof/pprof.go

@@ -20,8 +20,7 @@

"text/tabwriter"

)

-// BUG(rsc): A bug in the OS X Snow Leopard 64-bit kernel prevents

-// CPU profiling from giving accurate results on that system.

+// BUG(rsc): Profiles are incomplete and inaccuate on OS X. See http://golang.org/issue/6047 for details.

// A Profile is a collection of stack traces showing the call sequences

// that led to instances of a particular event, such as allocation.

« no previous file with comments | « src/pkg/runtime/os_windows.c ('k') | src/pkg/runtime/pprof/pprof_test.go » ('j') | no next file with comments »