src/pkg/runtime/lock_sema.c - Issue 12429045: code review 12429045: runtime/pprof: test multithreaded profile, remove OS X ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/runtime/lock_sema.c

Issue 12429045: code review 12429045: runtime/pprof: test multithreaded profile, remove OS X ... (Closed)

Patch Set: diff -r 1bac09ef43f0 https://code.google.com/p/go/ Created 11 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/pkg/runtime/lock_sema.c

===================================================================

--- a/src/pkg/runtime/lock_sema.c

+++ b/src/pkg/runtime/lock_sema.c

@@ -81,11 +81,7 @@

}

if(v&LOCKED) {

// Queued. Wait.

- if(m->profilehz > 0)

- runtime·setprof(false);

runtime·semasleep(-1);

- if(m->profilehz > 0)

- runtime·setprof(true);

i = 0;

}

@@ -164,11 +160,7 @@

return;

}

// Queued. Sleep.

- if(m->profilehz > 0)

- runtime·setprof(false);

runtime·semasleep(-1);

- if(m->profilehz > 0)

- runtime·setprof(true);

}

#pragma textflag 7

@@ -240,16 +232,11 @@

if(m->waitsema == 0)

m->waitsema = runtime·semacreate();

- if(m->profilehz > 0)

- runtime·setprof(false);

res = notetsleep(n, ns, 0, nil);

- if(m->profilehz > 0)

- runtime·setprof(true);

return res;

}

// same as runtime·notetsleep, but called on user g (not g0)

-// does not need to call runtime·setprof, because entersyscallblock does it

// calls only nosplit functions between entersyscallblock/exitsyscall

bool

runtime·notetsleepg(Note *n, int64 ns)

« no previous file with comments | « src/pkg/runtime/lock_futex.c ('k') | src/pkg/runtime/os_darwin.c » ('j') | no next file with comments »