Issue 124170043: Use DISALLOW_COPY_AND_ASSIGN consistently everywhere.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 124170043: Use DISALLOW_COPY_AND_ASSIGN consistently everywhere. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 8 months ago by roubert (google)

Modified:
9 years, 8 months ago

Reviewers:
Rouslan Solomakhin

Base URL:
https://libaddressinput.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Use DISALLOW_COPY_AND_ASSIGN consistently everywhere. Using this macro consistently for all classes that are not abstract or explicitly intended to be copyable can help preventing bugs. R=rouslan@chromium.org BUG= Committed: https://code.google.com/p/libaddressinput/source/detail?r=328

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+77 lines, -2 lines)			Patch
M	cpp/include/libaddressinput/localization.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	cpp/src/post_box_matchers.h	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	cpp/src/region_data_constants.h	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	cpp/src/validating_util.h	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	cpp/test/address_ui_test.cc	View	3 chunks	+9 lines, -0 lines	0 comments	Download
M	cpp/test/fake_storage.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	cpp/test/language_test.cc	View	2 chunks	+9 lines, -1 line	0 comments	Download
M	cpp/test/localization_test.cc	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	cpp/test/region_data_constants_test.cc	View	3 chunks	+14 lines, -1 line	0 comments	Download
M	cpp/test/rule_test.cc	View	5 chunks	+14 lines, -0 lines	0 comments	Download
M	cpp/test/util/string_compare_test.cc	View	2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

roubert (google)

9 years, 8 months ago (2014-08-12 17:05:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 328 (presubmit successful).

Expand All Messages | Collapse All Messages