Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

Issue 124110: * Allow unsetting Voice.instrumentCueName (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by Reinhold
Modified:
11 years ago
Reviewers:
Neil Puttock
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

* Allow unsetting Voice.instrumentCueName Don't assume that Voice.instrumentCueName is a valid markup! If it is empty (i.e. it has been manually unset), don't create an InstrumentSwitch grob.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
A input/regression/instrument-cue-name.ly View 1 chunk +18 lines, -0 lines 0 comments Download
M lily/instrument-switch-engraver.cc View 1 chunk +5 lines, -2 lines 1 comment Download

Messages

Total messages: 1
Neil Puttock
11 years ago (2009-10-06 19:05:14 UTC) #1
http://codereview.appspot.com/124110/diff/1/3
File lily/instrument-switch-engraver.cc (right):

http://codereview.appspot.com/124110/diff/1/3#newcode44
Line 44: if (!scm_is_null (cue_text))
I think

if (Text_interface::is_markup (cue_text))

would be more idiomatic here.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b