Issue 124110: * Allow unsetting Voice.instrumentCueName

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 124110: * Allow unsetting Voice.instrumentCueName (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 6 months ago by Reinhold

Modified:
14 years, 6 months ago

Reviewers:
Neil Puttock

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

* Allow unsetting Voice.instrumentCueName Don't assume that Voice.instrumentCueName is a valid markup! If it is empty (i.e. it has been manually unset), don't create an InstrumentSwitch grob.

Patch Set 1 #

Total comments: 1

Created: 14 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -2 lines)			Patch
	A	input/regression/instrument-cue-name.ly	View		1 chunk	+18 lines, -0 lines	0 comments	Download
	M	lily/instrument-switch-engraver.cc	View		1 chunk	+5 lines, -2 lines	1 comment	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Neil Puttock

14 years, 6 months ago (2009-10-06 19:05:14 UTC) #1

http://codereview.appspot.com/124110/diff/1/3
File lily/instrument-switch-engraver.cc (right):

http://codereview.appspot.com/124110/diff/1/3#newcode44
Line 44: if (!scm_is_null (cue_text))
I think

if (Text_interface::is_markup (cue_text))

would be more idiomatic here.

Expand All Messages | Collapse All Messages