Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(101)

Issue 124103: Fixes issue 1052: fastpath canSet test is inconsistent (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 6 months ago by MarkM
Modified:
16 years, 6 months ago
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

The fastpath test for property assignment was just testing whether the fastpath flag is truthy, which it might be for an inherited writable property. Instead, we now test that its value is the object itself (as the slow path test was already doing), in order to test that the own property is writable.

Patch Set 1 #

Patch Set 2 : Fixes issue 1052: fastpath canSet test is inconsistent #

Messages

Total messages: 3
MarkM
16 years, 6 months ago (2009-10-03 00:50:23 UTC) #1
MarkM
16 years, 6 months ago (2009-10-03 00:51:50 UTC) #2
ben
16 years, 6 months ago (2009-10-03 01:20:39 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b