Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(54)

Issue 124064: * Fix quoting overrides, set etc. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by Reinhold
Modified:
11 years, 2 months ago
Reviewers:
Neil Puttock
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

* Fix quoting overrides, set etc. The recording-group-emulate created the list of quoted events in reverse order, so we'll have to revert it again to be in the correct order. Also, allow all StreamEvent to be quoted (only those in quotedEventTypes will actually be quoted).

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -2 lines) Patch
A input/regression/quote-overrides.ly View 1 chunk +42 lines, -0 lines 2 comments Download
M scm/part-combiner.scm View 1 chunk +4 lines, -2 lines 2 comments Download

Messages

Total messages: 1
Neil Puttock
11 years, 2 months ago (2009-09-29 16:10:15 UTC) #1
LGTM.

There are a few trailing spaces in the regtest though.

Some of the lines in recording-group-emulate are far too long (particularly
where you've added the comment).

http://codereview.appspot.com/124064/diff/1/2
File input/regression/quote-overrides.ly (right):

http://codereview.appspot.com/124064/diff/1/2#newcode5
Line 5: @code{\\override}, @code{\\once\\override}, @code{\\revert},
@code{\\set},
space after \\once

http://codereview.appspot.com/124064/diff/1/2#newcode23
Line 23: % Checking \once\override
\once \override

http://codereview.appspot.com/124064/diff/1/3
File scm/part-combiner.scm (right):

http://codereview.appspot.com/124064/diff/1/3#newcode213
Line 213: ; The accumulate-event-listener above creates the list of events in
reverse order,
;;

http://codereview.appspot.com/124064/diff/1/3#newcode214
Line 214: ; so we have to revert it to be in the original order again
;;
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b