Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(18)

Issue 124053: Bug 763 : domita_test.js canonInnerHtml may be subverted (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 8 months ago by MikeSamuel
Modified:
16 years, 8 months ago
Reviewers:
metaweta
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

From http://code.google.com/p/google-caja/issues/detail?id=763 : (Originally found by Mike Stay.) The regex in domita_test.js canonInnerHtml that says: new RegExp('(<\\w+)\\s+([^\\s>][^>]*)>', 'g'), does not match the case where there are angle brackets *inside* an attribute, as in: <div id=">"> It seems that some browsers may get weird with escaping angle brackets (though Firefox 3 does the safe thing); see: http://groups.google.com/group/opera.beta/msg/32380d8ca64c3096 In any case, maybe worth a look to make sure we don't get spuriously failing or (worse) succeeding tests when regressing on multiple browsers. Submitted @3761

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M tests/com/google/caja/plugin/domita_test_untrusted.html View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 2
MikeSamuel
16 years, 8 months ago (2009-09-26 02:56:42 UTC) #1
metaweta
16 years, 8 months ago (2009-09-26 17:17:55 UTC) #2
On 2009/09/26 02:56:42, MikeSamuel wrote:
> 

lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b