Bug 714: el.innerHTML = undefined;

http://code.google.com/p/google-caja/issues/detail?id=714

    in browsers, that stringifies undefined and you see 'undefined'.
    in caja, domita.js setInnerHTML says
      sanitizeHtml(String(htmlFragment || ''))
    which turns undefined into '' instead.

    this is mostly an issue of developer-friendliness.  eg, someone
    says
      el.innerHTML = foo();
    and expects that to show something helpful, even if foo() is
    buggy.  instead, it shows nothing, and it's unclear whether the
    call to foo() happened at all.

Fixed setInnerHtml in DOMita and added tests.


Submitted @3755

[felix8a, 2009-09-25 23:08:11]

the rcdata logic is slightly confusing, it took a few tries to convince myself
that it's correct, but I don't see a way to simplify it.

lgtm

[felix8a, 2009-09-25 23:08:12]

the rcdata logic is slightly confusing, it took a few tries to convince myself
that it's correct, but I don't see a way to simplify it.

lgtm

[felix8a, 2009-09-25 23:22:16]

lgtm

http://codereview.appspot.com/124051/diff/1006/8
File src/com/google/caja/plugin/domita.js (right):

http://codereview.appspot.com/124051/diff/1006/8#newcode2265
Line 2265: htmlFragmentString = '' + htmlFragment;
oops, yeah.  sorry I didn't catch that.