Issue 124046: bug 580: get(Next|Previous)Sibling is a cuckoo

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 124046: bug 580: get(Next|Previous)Sibling is a cuckoo (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 8 months ago by MikeSamuel

Modified:
16 years, 8 months ago

Reviewers:
DavidSarah, metaweta

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Hardened to make sure that: To fix, we either need to disable them or present proof that we know the parent. holds. Submitted @3760

Patch Set 2 : bug 580: get(Next|Previous)Sibling is a cuckoo #

Total comments: 2

Created: 16 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -4 lines)			Patch
M	src/com/google/caja/plugin/Config.java	View	4 chunks	+10 lines, -0 lines	0 comments	Download
M	src/com/google/caja/plugin/PluginCompilerMain.java	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/com/google/caja/plugin/domita.js	View	1 chunk	+4 lines, -2 lines	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

DavidSarah

http://codereview.appspot.com/124046/diff/4/6 File src/com/google/caja/plugin/domita.js (left): http://codereview.appspot.com/124046/diff/4/6#oldcode1506 Line 1506: // TODO(mikesamuel): replace with cursors so that subtrees ...

16 years, 8 months ago (2009-09-26 09:05:06 UTC) #2

MikeSamuel

16 years, 8 months ago (2009-09-26 16:07:47 UTC) #3

metaweta

16 years, 8 months ago (2009-09-26 17:16:02 UTC) #4

On 2009/09/26 16:07:47, MikeSamuel wrote:
> http://codereview.appspot.com/124046/diff/4/6
> File src/com/google/caja/plugin/domita.js (left):
> 
> http://codereview.appspot.com/124046/diff/4/6#oldcode1506
> Line 1506: // TODO(mikesamuel): replace with cursors so that subtrees are
> delegable
> On 2009/09/26 09:05:06, DavidSarah wrote:
> > Is this comment still valid, or does the virtual iframe approach make it
moot?
> 
> Yes.  It's moot.

LGTM modulo removing the two copies of that comment.

Expand All Messages | Collapse All Messages