Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(141)

Issue 124045: Bug 541: Failure to load an external script is not fatal (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 6 months ago by MikeSamuel
Modified:
16 years, 6 months ago
Reviewers:
felix8a
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

http://code.google.com/p/google-caja/issues/detail?id=541 if <script src="..."> doesn't NPE ( issue 540 ) and the external js can't be loaded, caja emits PluginMessageType.FAILED_TO_LOAD_EXTERNAL_URL, which is a warning. Changed RewriteHtmlStage to throw an exception instead so that a user installed error handler can deal with it. Submitted @3762

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -2 lines) Patch
M src/com/google/caja/plugin/stages/RewriteHtmlStage.java View 2 chunks +7 lines, -2 lines 0 comments Download
M tests/com/google/caja/opensocial/example-rewritten.xml View 2 chunks +8 lines, -0 lines 0 comments Download
M tests/com/google/caja/plugin/stages/RewriteHtmlStageTest.java View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 2
MikeSamuel
16 years, 6 months ago (2009-09-25 19:18:35 UTC) #1
felix8a
16 years, 6 months ago (2009-09-27 20:17:04 UTC) #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b