Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(177)

Issue 124043: Added browser expectations test for issue 513 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 6 months ago by MikeSamuel
Modified:
16 years, 6 months ago
Reviewers:
DavidSarah, metaweta
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

From http://code.google.com/p/google-caja/issues/detail?id=513 Check for each browser that '({}) instanceof x' throws if x is not a function. We are assuming that, because the expansion of instanceof does not check that x is a function. ECMA-262 doesn't explicitly define the behaviour if it isn't. Submitted @3745

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M tests/com/google/caja/browser-expectations.html View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 3
MikeSamuel
16 years, 6 months ago (2009-09-25 16:47:35 UTC) #1
DavidSarah
LGTM.
16 years, 6 months ago (2009-09-25 18:03:55 UTC) #2
metaweta
16 years, 6 months ago (2009-09-26 17:12:57 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b