Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4220)

Issue 1238044: code review 1238044: Provide advice on using Mercurial Queues in conjunction...

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by pwil3058
Modified:
11 years, 1 month ago
Reviewers:
rsc1
CC:
rsc, r, golang-dev
Visibility:
Public.

Description

Provide advice on using Mercurial Queues in conjunction with codreview

Patch Set 1 #

Patch Set 2 : code review 1238044: Provide advice on using Mercurial Queues in conjunction... #

Total comments: 5

Patch Set 3 : code review 1238044: Provide advice on using Mercurial Queues in conjunction... #

Total comments: 20

Patch Set 4 : code review 1238044: Provide advice on using Mercurial Queues in conjunction... #

Total comments: 10

Patch Set 5 : code review 1238044: Provide advice on using Mercurial Queues in conjunction... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -4 lines) Patch
A doc/codereview_with_mq.html View 3 4 1 chunk +113 lines, -0 lines 0 comments Download
M doc/contribute.html View 1 2 3 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 17
pwil3058
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
11 years, 2 months ago (2010-05-21 01:00:13 UTC) #1
r
http://codereview.appspot.com/1238044/diff/2001/3001 File doc/contribute.html (right): http://codereview.appspot.com/1238044/diff/2001/3001#newcode106 doc/contribute.html:106: The Mercurial Queues (<strong>MQ</strong>) extension provides a mechanism for ...
11 years, 2 months ago (2010-05-21 18:29:24 UTC) #2
rsc
Thanks for writing all this down. Perhaps it makes sense as a separate section or ...
11 years, 2 months ago (2010-05-21 19:37:39 UTC) #3
pwil3058
On 22/05/10 04:29, r@golang.org wrote: > > http://codereview.appspot.com/1238044/diff/2001/3001 > File doc/contribute.html (right): > > http://codereview.appspot.com/1238044/diff/2001/3001#newcode106 ...
11 years, 2 months ago (2010-05-21 23:46:56 UTC) #4
pwil3058
On 22/05/10 05:37, Russ Cox wrote: > Thanks for writing all this down. > Perhaps ...
11 years, 2 months ago (2010-05-22 00:06:11 UTC) #5
rsc
> The main problem I'll face doing this is testing. Is there a way I ...
11 years, 2 months ago (2010-05-22 00:34:58 UTC) #6
pwil3058
On 22/05/10 10:34, Russ Cox wrote: >> The main problem I'll face doing this is ...
11 years, 2 months ago (2010-05-22 00:57:04 UTC) #7
pwil3058
Hello rsc, r (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 2 months ago (2010-05-26 01:38:15 UTC) #8
rsc1
Looks pretty good; thanks for writing all this down (and getting it working!). http://codereview.appspot.com/1238044/diff/13001/14001 File ...
11 years, 2 months ago (2010-06-01 21:17:49 UTC) #9
pwil3058
If these actions are OK let me know and I'll send a revised patch. http://codereview.appspot.com/1238044/diff/13001/14001 ...
11 years, 2 months ago (2010-06-02 00:13:20 UTC) #10
rsc
I can't see if they're OK unless you send a revised patch. ;-) On Tue, ...
11 years, 2 months ago (2010-06-02 02:19:32 UTC) #11
pwil3058
Hello rsc, r (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 2 months ago (2010-06-02 04:24:59 UTC) #12
r
minor comments only. it's pretty good, if a bit repetitive, which is not a bad ...
11 years, 2 months ago (2010-06-02 04:31:55 UTC) #13
pwil3058
Hello rsc, r (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 2 months ago (2010-06-02 05:33:32 UTC) #14
pwil3058
http://codereview.appspot.com/1238044/diff/22001/23001 File doc/codereview_with_mq.html (right): http://codereview.appspot.com/1238044/diff/22001/23001#newcode21 doc/codereview_with_mq.html:21: To enable the <code>mq</code> edit either <code>$HOME/.hgrc</code> (to enable ...
11 years, 2 months ago (2010-06-02 05:37:32 UTC) #15
rsc1
LGTM
11 years, 1 month ago (2010-06-03 00:04:09 UTC) #16
rsc
11 years, 1 month ago (2010-06-03 00:11:55 UTC) #17
*** Submitted as http://code.google.com/p/go/source/detail?r=433cbad2f237 ***

doc: codereview + Mercurial Queues

R=rsc, r
CC=golang-dev
http://codereview.appspot.com/1238044

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b