Introduce UI for changing benchmark configuration

Introduce UI for changing benchmark configuration

Also merges parameter and config

R=ricea@chromium.org

Committed: https://code.google.com/p/pywebsocket/source/detail?r=828

[tyoshino (chromium.org), 2014-08-22 04:34:34]

On 2014/08/06 07:57:52, tyoshino (Chromium) wrote:

ping

[Adam Rice, 2014-08-27 06:47:50]

Sorry for lack of response.

https://codereview.appspot.com/123790044/diff/20001/src/example/benchmark.html
File src/example/benchmark.html (right):

https://codereview.appspot.com/123790044/diff/20001/src/example/benchmark.htm...
src/example/benchmark.html:249: return array;
You could use

...value.split(',').map(function(s) { return parseInt(s, 10); })

I don't think the call to trim is needed. It's up to you.

https://codereview.appspot.com/123790044/diff/20001/src/example/benchmark.htm...
src/example/benchmark.html:252: function getConfig(id) {
id parameter unused?

https://codereview.appspot.com/123790044/diff/20001/src/example/benchmark.htm...
src/example/benchmark.html:274: getIntFromInput('startsize'),
Include in config? Also 'numsockets', below.

https://codereview.appspot.com/123790044/diff/20001/src/example/benchmark.htm...
src/example/benchmark.html:330: Print size and time per message
Extreme nit: how about using <label for="printsize">Print size and time per
message</label> ?

https://codereview.appspot.com/123790044/diff/20001/src/example/benchmark.htm...
src/example/benchmark.html:340: Num sockets: <input type="text" id="numsockets"
value="1">
Optional: layout the parameters in a table maybe?

[tyoshino (chromium.org), 2014-08-27 09:20:24]

Thanks

https://codereview.appspot.com/123790044/diff/20001/src/example/benchmark.html
File src/example/benchmark.html (right):

https://codereview.appspot.com/123790044/diff/20001/src/example/benchmark.htm...
src/example/benchmark.html:249: return array;
On 2014/08/27 06:47:50, Adam Rice wrote:
> You could use
> 
> ...value.split(',').map(function(s) { return parseInt(s, 10); })
> 
> I don't think the call to trim is needed. It's up to you.

Thanks. Used map and removed trim().

https://codereview.appspot.com/123790044/diff/20001/src/example/benchmark.htm...
src/example/benchmark.html:252: function getConfig(id) {
On 2014/08/27 06:47:50, Adam Rice wrote:
> id parameter unused?

Oh. Removed

https://codereview.appspot.com/123790044/diff/20001/src/example/benchmark.htm...
src/example/benchmark.html:274: getIntFromInput('startsize'),
On 2014/08/27 06:47:50, Adam Rice wrote:
> Include in config? Also 'numsockets', below.

Done.

https://codereview.appspot.com/123790044/diff/20001/src/example/benchmark.htm...
src/example/benchmark.html:330: Print size and time per message
On 2014/08/27 06:47:50, Adam Rice wrote:
> Extreme nit: how about using <label for="printsize">Print size and time per
> message</label> ?

Nice suggestion! Done

https://codereview.appspot.com/123790044/diff/20001/src/example/benchmark.htm...
src/example/benchmark.html:340: Num sockets: <input type="text" id="numsockets"
value="1">
On 2014/08/27 06:47:50, Adam Rice wrote:
> Optional: layout the parameters in a table maybe?

Done.

https://codereview.appspot.com/123790044/diff/80001/src/example/benchmark.html
File src/example/benchmark.html (right):

https://codereview.appspot.com/123790044/diff/80001/src/example/benchmark.htm...
src/example/benchmark.html:334: Parameters:
fixed.

Send parameters -> Parameters

[Adam Rice, 2014-08-28 03:40:30]

https://codereview.appspot.com/123790044/diff/80001/src/example/benchmark.html
File src/example/benchmark.html (right):

https://codereview.appspot.com/123790044/diff/80001/src/example/benchmark.htm...
src/example/benchmark.html:330: <label for="printsize">Verify data</label>
s/printsize/verifydata/

[tyoshino (chromium.org), 2014-08-28 04:17:47]

https://codereview.appspot.com/123790044/diff/80001/src/example/benchmark.html
File src/example/benchmark.html (right):

https://codereview.appspot.com/123790044/diff/80001/src/example/benchmark.htm...
src/example/benchmark.html:330: <label for="printsize">Verify data</label>
On 2014/08/28 03:40:30, Adam Rice wrote:
> s/printsize/verifydata/

Ahhh! Fixed

[Adam Rice, 2014-08-28 09:31:37]

lgtm

[tyoshino (chromium.org), 2014-08-29 07:38:45]

Committed patchset #6 manually as r828 (presubmit successful).