Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(118)

Issue 12377044: Return None if the decorator threadlocal store doesn't have flow or credentials. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by jcgregorio_google
Modified:
11 years, 11 months ago
CC:
google-api-python-client_googlegroups.com
Visibility:
Public.

Description

Return None if the decorator threadlocal store doesn't have flow or credentials.

Patch Set 1 #

Total comments: 6

Patch Set 2 : simplify #

Total comments: 2

Patch Set 3 : pydoc #

Total comments: 1

Patch Set 4 : more pydoc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M oauth2client/appengine.py View 1 2 3 1 chunk +18 lines, -3 lines 0 comments Download
M tests/test_oauth2client_appengine.py View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9
jcgregorio_google
11 years, 11 months ago (2013-08-05 19:51:52 UTC) #1
dhermes
https://codereview.appspot.com/12377044/diff/1/oauth2client/appengine.py File oauth2client/appengine.py (right): https://codereview.appspot.com/12377044/diff/1/oauth2client/appengine.py#newcode577 oauth2client/appengine.py:577: def get_credentials(self): Docstring, now given the added complexity? https://codereview.appspot.com/12377044/diff/1/oauth2client/appengine.py#newcode578 ...
11 years, 11 months ago (2013-08-05 19:55:57 UTC) #2
jcgregorio_google
https://codereview.appspot.com/12377044/diff/1/oauth2client/appengine.py File oauth2client/appengine.py (right): https://codereview.appspot.com/12377044/diff/1/oauth2client/appengine.py#newcode578 oauth2client/appengine.py:578: if hasattr(self._tls, 'credentials'): On 2013/08/05 19:55:58, dhermes wrote: > ...
11 years, 11 months ago (2013-08-06 13:26:35 UTC) #3
dhermes
https://codereview.appspot.com/12377044/diff/5001/oauth2client/appengine.py File oauth2client/appengine.py (right): https://codereview.appspot.com/12377044/diff/5001/oauth2client/appengine.py#newcode577 oauth2client/appengine.py:577: def get_credentials(self): And the docstring? Explain why self._tls might ...
11 years, 11 months ago (2013-08-06 15:26:06 UTC) #4
jcgregorio_google
https://codereview.appspot.com/12377044/diff/1/oauth2client/appengine.py File oauth2client/appengine.py (right): https://codereview.appspot.com/12377044/diff/1/oauth2client/appengine.py#newcode577 oauth2client/appengine.py:577: def get_credentials(self): On 2013/08/05 19:55:58, dhermes wrote: > Docstring, ...
11 years, 11 months ago (2013-08-06 15:39:09 UTC) #5
dhermes
https://codereview.appspot.com/12377044/diff/12001/oauth2client/appengine.py File oauth2client/appengine.py (right): https://codereview.appspot.com/12377044/diff/12001/oauth2client/appengine.py#newcode578 oauth2client/appengine.py:578: """Returns the threadlocal store copy of credentials, or None ...
11 years, 11 months ago (2013-08-06 15:42:04 UTC) #6
jcgregorio_google
On 2013/08/06 15:42:04, dhermes wrote: > https://codereview.appspot.com/12377044/diff/12001/oauth2client/appengine.py > File oauth2client/appengine.py (right): > > https://codereview.appspot.com/12377044/diff/12001/oauth2client/appengine.py#newcode578 > ...
11 years, 11 months ago (2013-08-06 16:04:13 UTC) #7
dhermes
On 2013/08/06 16:04:13, jcgregorio_google wrote: > On 2013/08/06 15:42:04, dhermes wrote: > > https://codereview.appspot.com/12377044/diff/12001/oauth2client/appengine.py > ...
11 years, 11 months ago (2013-08-06 16:05:31 UTC) #8
jcgregorio_google
11 years, 11 months ago (2013-08-06 18:51:14 UTC) #9
On 2013/08/06 16:05:31, dhermes wrote:
> On 2013/08/06 16:04:13, jcgregorio_google wrote:
> > On 2013/08/06 15:42:04, dhermes wrote:
> > >
https://codereview.appspot.com/12377044/diff/12001/oauth2client/appengine.py
> > > File oauth2client/appengine.py (right):
> > > 
> > >
> >
>
https://codereview.appspot.com/12377044/diff/12001/oauth2client/appengine.py#...
> > > oauth2client/appengine.py:578: """Returns the threadlocal store copy of
> > > credentials, or None if
> > > Can you make this a real docstring i.e. actually fit on one line and then
> > > extended description after?
> > > 
> > > Also, in what situations will people call get_credentials before the
> > credentials
> > > have been set in the thread?
> > 
> > Done.
> 
> Awesome docs!
> 
> LGTM

Committed in
https://code.google.com/p/google-api-python-client/source/detail?r=92145cdcc8...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b