Return None if the decorator threadlocal store doesn't have flow or credentials.

Return None if the decorator threadlocal store doesn't have flow or credentials.

[dhermes, 2013-08-05 19:55:57]

https://codereview.appspot.com/12377044/diff/1/oauth2client/appengine.py
File oauth2client/appengine.py (right):

https://codereview.appspot.com/12377044/diff/1/oauth2client/appengine.py#newc...
oauth2client/appengine.py:577: def get_credentials(self):
Docstring, now given the added complexity?

https://codereview.appspot.com/12377044/diff/1/oauth2client/appengine.py#newc...
oauth2client/appengine.py:578: if hasattr(self._tls, 'credentials'):
Why not

return getattr(self._tls, 'credentials', None)

?

https://codereview.appspot.com/12377044/diff/1/oauth2client/appengine.py#newc...
oauth2client/appengine.py:580: return None
This isn't necessary. No return statement equivalent to None.

[jcgregorio_google, 2013-08-06 13:26:35]

https://codereview.appspot.com/12377044/diff/1/oauth2client/appengine.py
File oauth2client/appengine.py (right):

https://codereview.appspot.com/12377044/diff/1/oauth2client/appengine.py#newc...
oauth2client/appengine.py:578: if hasattr(self._tls, 'credentials'):
On 2013/08/05 19:55:58, dhermes wrote:
> Why not
> 
> return getattr(self._tls, 'credentials', None)
> 
> ?

Done.

https://codereview.appspot.com/12377044/diff/1/oauth2client/appengine.py#newc...
oauth2client/appengine.py:580: return None
On 2013/08/05 19:55:58, dhermes wrote:
> This isn't necessary. No return statement equivalent to None.

Done.

[dhermes, 2013-08-06 15:26:06]

https://codereview.appspot.com/12377044/diff/5001/oauth2client/appengine.py
File oauth2client/appengine.py (right):

https://codereview.appspot.com/12377044/diff/5001/oauth2client/appengine.py#n...
oauth2client/appengine.py:577: def get_credentials(self):
And the docstring? Explain why self._tls might not have credentials set.

https://codereview.appspot.com/12377044/diff/5001/oauth2client/appengine.py#n...
oauth2client/appengine.py:583: def get_flow(self):
Ditto here

[jcgregorio_google, 2013-08-06 15:39:09]

https://codereview.appspot.com/12377044/diff/1/oauth2client/appengine.py
File oauth2client/appengine.py (right):

https://codereview.appspot.com/12377044/diff/1/oauth2client/appengine.py#newc...
oauth2client/appengine.py:577: def get_credentials(self):
On 2013/08/05 19:55:58, dhermes wrote:
> Docstring, now given the added complexity?

Done.

[dhermes, 2013-08-06 15:42:04]

https://codereview.appspot.com/12377044/diff/12001/oauth2client/appengine.py
File oauth2client/appengine.py (right):

https://codereview.appspot.com/12377044/diff/12001/oauth2client/appengine.py#...
oauth2client/appengine.py:578: """Returns the threadlocal store copy of
credentials, or None if
Can you make this a real docstring i.e. actually fit on one line and then
extended description after?

Also, in what situations will people call get_credentials before the credentials
have been set in the thread?

[jcgregorio_google, 2013-08-06 16:04:13]

On 2013/08/06 15:42:04, dhermes wrote:
> https://codereview.appspot.com/12377044/diff/12001/oauth2client/appengine.py
> File oauth2client/appengine.py (right):
> 
>
https://codereview.appspot.com/12377044/diff/12001/oauth2client/appengine.py#...
> oauth2client/appengine.py:578: """Returns the threadlocal store copy of
> credentials, or None if
> Can you make this a real docstring i.e. actually fit on one line and then
> extended description after?
> 
> Also, in what situations will people call get_credentials before the
credentials
> have been set in the thread?

Done.

[dhermes, 2013-08-06 16:05:31]

On 2013/08/06 16:04:13, jcgregorio_google wrote:
> On 2013/08/06 15:42:04, dhermes wrote:
> > https://codereview.appspot.com/12377044/diff/12001/oauth2client/appengine.py
> > File oauth2client/appengine.py (right):
> > 
> >
>
https://codereview.appspot.com/12377044/diff/12001/oauth2client/appengine.py#...
> > oauth2client/appengine.py:578: """Returns the threadlocal store copy of
> > credentials, or None if
> > Can you make this a real docstring i.e. actually fit on one line and then
> > extended description after?
> > 
> > Also, in what situations will people call get_credentials before the
> credentials
> > have been set in the thread?
> 
> Done.

Awesome docs!

LGTM

[jcgregorio_google, 2013-08-06 18:51:14]

On 2013/08/06 16:05:31, dhermes wrote:
> On 2013/08/06 16:04:13, jcgregorio_google wrote:
> > On 2013/08/06 15:42:04, dhermes wrote:
> > >
https://codereview.appspot.com/12377044/diff/12001/oauth2client/appengine.py
> > > File oauth2client/appengine.py (right):
> > > 
> > >
> >
>
https://codereview.appspot.com/12377044/diff/12001/oauth2client/appengine.py#...
> > > oauth2client/appengine.py:578: """Returns the threadlocal store copy of
> > > credentials, or None if
> > > Can you make this a real docstring i.e. actually fit on one line and then
> > > extended description after?
> > > 
> > > Also, in what situations will people call get_credentials before the
> > credentials
> > > have been set in the thread?
> > 
> > Done.
> 
> Awesome docs!
> 
> LGTM

Committed in
https://code.google.com/p/google-api-python-client/source/detail?r=92145cdcc8...