Only decode JSON as utf-8.

Only decode JSON as utf-8.

[dhermes, 2013-08-02 21:00:37]

What change introduced this regression?
How does moving it to deserialize help?

[jcgregorio_google, 2013-08-02 21:08:10]

On Fri, Aug 2, 2013 at 5:00 PM, <dhermes@google.com> wrote:

> What change introduced this regression?
>

We were running into bugs with some JSON parsers that didn't convert
the string to unicode themselves and would choke on some input.


> How does moving it to deserialize help?
>

Converting the string to unicode is the wrong thing to do
if you have a protocol buffer model, this change
moves it to JsonModel.deserialize() where it should
have been from the beginning.


>
>
https://codereview.appspot.**com/12377043/<https://codereview.appspot.com/123...
>

[dhermes, 2013-08-02 21:21:13]

Ahhh! Of course, deserialize works differently for different models.

LGTM


On Fri, Aug 2, 2013 at 2:07 PM, Joe Gregorio <jcgregorio@google.com> wrote:

>
>
>
> On Fri, Aug 2, 2013 at 5:00 PM, <dhermes@google.com> wrote:
>
>> What change introduced this regression?
>>
>
> We were running into bugs with some JSON parsers that didn't convert
> the string to unicode themselves and would choke on some input.
>
>
>> How does moving it to deserialize help?
>>
>
> Converting the string to unicode is the wrong thing to do
> if you have a protocol buffer model, this change
> moves it to JsonModel.deserialize() where it should
> have been from the beginning.
>
>
>>
>>
https://codereview.appspot.**com/12377043/<https://codereview.appspot.com/123...
>>
>
>


-- 
Danny Hermes
Developer Programs Engineer

[jcgregorio_google, 2013-08-02 21:22:39]

Committed in
https://code.google.com/p/google-api-python-client/source/detail?r=e0a759d1c8...

On 2013/08/02 21:21:13, dhermes wrote:
> Ahhh! Of course, deserialize works differently for different models.
> 
> LGTM
> 
> 
> On Fri, Aug 2, 2013 at 2:07 PM, Joe Gregorio <mailto:jcgregorio@google.com>
wrote:
> 
> >
> >
> >
> > On Fri, Aug 2, 2013 at 5:00 PM, <mailto:dhermes@google.com> wrote:
> >
> >> What change introduced this regression?
> >>
> >
> > We were running into bugs with some JSON parsers that didn't convert
> > the string to unicode themselves and would choke on some input.
> >
> >
> >> How does moving it to deserialize help?
> >>
> >
> > Converting the string to unicode is the wrong thing to do
> > if you have a protocol buffer model, this change
> > moves it to JsonModel.deserialize() where it should
> > have been from the beginning.
> >
> >
> >>
> >>
>
https://codereview.appspot.**com/12377043/%3Chttps://codereview.appspot.com/1...>
> >>
> >
> >
> 
> 
> -- 
> Danny Hermes
> Developer Programs Engineer