Move MemoryNotifierAllocator to its own file, and create HeapAllocator.

Move MemoryNotifierAllocator to its own file, and create HeapAllocator.

Turns out that MemoryNotifierAllocator isn't going to cut it for us, because the STL heap does alignments mod 4, and the
shadow memory barfs. The new approach will be to use a HeapAllocator combined with an instance of a reporting heap
(either a WinHeap or a CtMallocHeap), and have internal STL structures use *that*.

BUG=
R=sebmarchand@chromium.org

Committed: https://code.google.com/p/sawbuck/source/detail?r=2263

[chrisha, 2014-08-19 17:23:26]

PTAL?

[Sébastien Marchand, 2014-08-19 18:20:27]

https://codereview.appspot.com/123350045/diff/20001/syzygy/agent/asan/allocat...
File syzygy/agent/asan/allocators_unittest.cc (right):

https://codereview.appspot.com/123350045/diff/20001/syzygy/agent/asan/allocat...
syzygy/agent/asan/allocators_unittest.cc:160: typedef
testing::StrictMock<LenientMockHeap> MockHeap;
Hum, it looks like the same class that's already defined in
windows_heap_adapter_unittest.cc... Maybe put this in a common place ?
(unittest_utils)

[chrisha, 2014-08-19 18:26:41]

https://codereview.appspot.com/123350045/diff/20001/syzygy/agent/asan/allocat...
File syzygy/agent/asan/allocators_unittest.cc (right):

https://codereview.appspot.com/123350045/diff/20001/syzygy/agent/asan/allocat...
syzygy/agent/asan/allocators_unittest.cc:160: typedef
testing::StrictMock<LenientMockHeap> MockHeap;
On 2014/08/19 18:20:26, Sébastien Marchand wrote:
> Hum, it looks like the same class that's already defined in
> windows_heap_adapter_unittest.cc... Maybe put this in a common place ?
> (unittest_utils)

No, you mock a HeapManager there, not a Heap. But I've moved it there anyways :)

[Sébastien Marchand, 2014-08-19 18:35:10]

lgtm.

https://codereview.appspot.com/123350045/diff/20001/syzygy/agent/asan/allocat...
File syzygy/agent/asan/allocators_unittest.cc (right):

https://codereview.appspot.com/123350045/diff/20001/syzygy/agent/asan/allocat...
syzygy/agent/asan/allocators_unittest.cc:160: typedef
testing::StrictMock<LenientMockHeap> MockHeap;
On 2014/08/19 18:26:41, chrisha wrote:
> On 2014/08/19 18:20:26, Sébastien Marchand wrote:
> > Hum, it looks like the same class that's already defined in
> > windows_heap_adapter_unittest.cc... Maybe put this in a common place ?
> > (unittest_utils)
> 
> No, you mock a HeapManager there, not a Heap. But I've moved it there anyways
:)

Oops, I read it too quickly.

[chrisha, 2014-08-19 18:42:01]

Thanks, committing!

[chrisha, 2014-08-19 18:43:00]

Committed patchset #3 manually as 2263 (presubmit successful).