Issue 123350044: Delete empty inline destructors.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 123350044: Delete empty inline destructors. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by roubert (google)

Modified:
9 years, 8 months ago

Reviewers:
Rouslan Solomakhin

Base URL:
https://libaddressinput.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Delete empty inline destructors. These destructor definitions don't add any value over just depending on the implicitly-defined destructors. R=rouslan@chromium.org BUG= Committed: https://code.google.com/p/libaddressinput/source/detail?r=331

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -36 lines)			Patch
M	cpp/test/address_input_helper_test.cc	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	cpp/test/address_normalizer_test.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	cpp/test/address_validator_test.cc	View	3 chunks	+0 lines, -6 lines	0 comments	Download
M	cpp/test/fake_storage_test.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	cpp/test/null_storage_test.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	cpp/test/preload_supplier_test.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	cpp/test/region_data_builder_test.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	cpp/test/retriever_test.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	cpp/test/rule_retriever_test.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	cpp/test/supplier_test.cc	View	3 chunks	+0 lines, -6 lines	0 comments	Download
M	cpp/test/testdata_source_test.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	cpp/test/validating_storage_test.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	cpp/test/validation_task_test.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

roubert (google)

9 years, 8 months ago (2014-08-13 20:20:04 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 331 (presubmit successful).

Expand All Messages | Collapse All Messages