Issue 1232044: Use UriCommon from AbstractHttpCache

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1232044: Use UriCommon from AbstractHttpCache

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 10 months ago by zhoresh

Modified:
15 years, 10 months ago

Reviewers:
henry.saputra, shindig.remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk

Visibility:
Public.

Description

Simple dependency cleanup and use of UriCommon instead of ImageRewriter.

Patch Set 1 #

Total comments: 1

Created: 15 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -7 lines)			Patch
		java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java	View		2 chunks	+4 lines, -7 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

henry.saputra

LGTM with small comment. http://codereview.appspot.com/1232044/diff/1/2 File java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java (right): http://codereview.appspot.com/1232044/diff/1/2#newcode152 java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java:152: .setParam("rh", request.getParam(UriCommon.Param.RESIZE_HEIGHT.getKey())) Since the UriCommon.Param ...

15 years, 10 months ago (2010-05-20 16:20:28 UTC) #2

zhoresh

15 years, 10 months ago (2010-05-20 17:29:26 UTC) #3

Thanks. Updated and committed.

On Thu, May 20, 2010 at 9:20 AM, <henry.saputra@gmail.com> wrote:

> LGTM with small comment.
>
>
> http://codereview.appspot.com/1232044/diff/1/2
> File
>
>
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java
> (right):
>
> http://codereview.appspot.com/1232044/diff/1/2#newcode152
>
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java:152:
>
> .setParam("rh",
> request.getParam(UriCommon.Param.RESIZE_HEIGHT.getKey()))
> Since the UriCommon.Param enums are used simply as String to get data
> from request parameter, maybe could use private final String to store
> the params like in BasicImageRewriter class.
>
>
> http://codereview.appspot.com/1232044/show
>

Expand All Messages | Collapse All Messages