Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(125)

Issue 12306043: Insert query strings as temporary cache hack

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by gary.poster
Modified:
10 years, 9 months ago
Reviewers:
rharding, frankban, mp+178184, jeff.pihach
Visibility:
Public.

Description

Insert query strings as temporary cache hack Once we deploy Benji's cache header GUI charm upgrade and make a release with the index.html hacks, we can take the query string silliness out again. Meanwhile, it is a cheap way to try and get updated files before we get the headers in place. The "sprite" -> "sprites" is another silly way to force a reload, but we can keep that one <shrug>. This also includes commenting out the recent SASS changes, because they could not be built in the charm. It looks like the charm needs to add g++ as a build depedendency too. https://code.launchpad.net/~gary/juju-gui/hackreleasefiles/+merge/178184 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -389 lines) Patch
M Makefile View 3 chunks +6 lines, -6 lines 0 comments Download
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/index.html View 4 chunks +26 lines, -24 lines 0 comments Download
M grunt.js View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/templates.js View 3 chunks +3 lines, -3 lines 0 comments Download
M npm-shrinkwrap.json View 14 chunks +268 lines, -353 lines 0 comments Download
M package.json View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5
gary.poster
Please take a look.
10 years, 9 months ago (2013-08-02 01:15:51 UTC) #1
rharding
LGTM assuming the npm stuff was automatic/generated. I think this helps make the case for ...
10 years, 9 months ago (2013-08-02 01:45:21 UTC) #2
jeff.pihach
Code LGTM.
10 years, 9 months ago (2013-08-02 05:34:31 UTC) #3
frankban
Code LGTM, thank you Gary! There is a problem with the internal Python server not ...
10 years, 9 months ago (2013-08-02 08:53:28 UTC) #4
frankban
10 years, 9 months ago (2013-08-02 09:38:01 UTC) #5
Landed, see https://codereview.appspot.com/12335043/
That branch includes the Python HTTP server fix.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b