Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(725)

Issue 122490043: Give unique ids to the trybot category divs (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by rmistry
Modified:
11 years ago
Visibility:
Public.

Description

Give unique ids to the trybot category divs This change is staged here: https://skia-codereview-staging.appspot.com/451004/ BUG= https://code.google.com/p/chromium/issues/detail?id=403340

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M codereview/library.py View 5 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 5
rmistry
11 years ago (2014-08-13 15:12:38 UTC) #1
jrobbins (corp)
lgtm. In looking at the staging server, I notice that the master name is client.skia, ...
11 years ago (2014-08-13 15:31:38 UTC) #2
rmistry
On 2014/08/13 15:31:38, jrobbins (corp) wrote: > lgtm. > > In looking at the staging ...
11 years ago (2014-08-13 16:32:01 UTC) #3
rmistry
Submitted as https://code.google.com/p/rietveld/source/detail?r=8ca370189bc7ef6b40aebb734e5656c62f08c087&name=chromium
11 years ago (2014-08-13 16:36:37 UTC) #4
rmistry
11 years ago (2014-08-13 16:47:15 UTC) #5
Message was sent while issue was closed.
On 2014/08/13 16:32:01, rmistry wrote:
> On 2014/08/13 15:31:38, jrobbins (corp) wrote:
> > lgtm.
> > 
> > In looking at the staging server, I notice that the master name is
> client.skia,
> > whereas everything else is tryserver.*.   Would it make sense to name it
> > tryserver.skia.client so that it is grouped alphabetically with the other
skia
> > masters?
> 
> Not sure, I will check with borenet@ and will upload a separate CL to rename
if
> he agrees.

borenet@ says "yeah in try_job_rietveld there's a filter_by_master which we're
using so it has to be client.skia". So unfortunately we will not be able to
change the name to tryserver.skia.client. However one day client.skia will
completely replace tryserver.skia.client.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b