Issue 122048: Fixed NPE on a:link splitting.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 122048: Fixed NPE on a:link splitting. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 6 months ago by MikeSamuel

Modified:
16 years, 6 months ago

Reviewers:
Jasvir

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

I was running the example bin/cajole_html <(echo '<div style="color:\"></div>') This failed with a null pointer exception because CssRewriter.rewriteHistorySensitiveRuleset was lazily creating lists in a widgy way. I also changed PluginCompilerMain and Config so that I can run cajole_html from the command line as in the example above. Previously, it objected to named pipes. Submitted @3738

Patch Set 1 #

Created: 16 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -33 lines)			Patch
M	src/com/google/caja/lexer/CharProducer.java	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/com/google/caja/plugin/Config.java	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/com/google/caja/plugin/CssRewriter.java	View	4 chunks	+20 lines, -19 lines	0 comments	Download
M	src/com/google/caja/plugin/PluginCompilerMain.java	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	tests/com/google/caja/parser/css/CssParserTest.java	View	2 chunks	+28 lines, -5 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages