Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(443)

Issue 121870043: ICU ticket #10939: ICU4J optionally read data from .dat and .res (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 1 month ago by markus.icu
Modified:
3 years, 1 month ago
Reviewers:
roubert (google)
Base URL:
http://source.icu-project.org/repos/icu/icu4j/branches/markus/mapdata/
Visibility:
Public.

Description

branch code complete at r36098

Patch Set 1 #

Total comments: 38

Patch Set 2 : code review changes r36102 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1160 lines, -645 lines) Patch
M main/classes/charset/src/com/ibm/icu/charset/CharsetCallback.java View 1 7 chunks +10 lines, -12 lines 0 comments Download
M main/classes/charset/src/com/ibm/icu/charset/CharsetISO2022.java View 1 2 chunks +4 lines, -4 lines 0 comments Download
M main/classes/charset/src/com/ibm/icu/charset/CharsetMBCS.java View 1 60 chunks +260 lines, -279 lines 0 comments Download
M main/classes/charset/src/com/ibm/icu/charset/UConverterAlias.java View 1 4 chunks +3 lines, -20 lines 0 comments Download
M main/classes/charset/src/com/ibm/icu/charset/UConverterDataReader.java View 1 7 chunks +123 lines, -97 lines 0 comments Download
M main/classes/collate/src/com/ibm/icu/impl/coll/CollationRoot.java View 1 2 chunks +9 lines, -10 lines 0 comments Download
M main/classes/core/src/com/ibm/icu/ICUConfig.properties View 1 3 chunks +13 lines, -2 lines 0 comments Download
M main/classes/core/src/com/ibm/icu/impl/ICUBinary.java View 1 6 chunks +416 lines, -9 lines 0 comments Download
M main/classes/core/src/com/ibm/icu/impl/ICUData.java View 1 5 chunks +109 lines, -18 lines 0 comments Download
M main/classes/core/src/com/ibm/icu/impl/ICUResourceBundle.java View 1 1 chunk +41 lines, -17 lines 0 comments Download
M main/classes/core/src/com/ibm/icu/impl/ICUResourceBundleReader.java View 1 7 chunks +30 lines, -40 lines 0 comments Download
M main/classes/core/src/com/ibm/icu/impl/Norm2AllModes.java View 1 2 chunks +2 lines, -3 lines 0 comments Download
M main/classes/core/src/com/ibm/icu/impl/Normalizer2Impl.java View 1 1 chunk +1 line, -5 lines 0 comments Download
M main/classes/core/src/com/ibm/icu/impl/Trie2.java View 1 1 chunk +4 lines, -2 lines 0 comments Download
M main/classes/core/src/com/ibm/icu/impl/UBiDiProps.java View 1 2 chunks +1 line, -3 lines 0 comments Download
M main/classes/core/src/com/ibm/icu/impl/UCaseProps.java View 1 2 chunks +1 line, -3 lines 0 comments Download
M main/classes/core/src/com/ibm/icu/impl/UCharacterName.java View 1 3 chunks +2 lines, -4 lines 0 comments Download
M main/classes/core/src/com/ibm/icu/impl/UCharacterProperty.java View 1 3 chunks +2 lines, -4 lines 0 comments Download
M main/classes/core/src/com/ibm/icu/impl/UPropertyAliases.java View 1 2 chunks +1 line, -3 lines 0 comments Download
M main/classes/core/src/com/ibm/icu/impl/duration/impl/ResourceBasedPeriodFormatterDataService.java View 1 2 chunks +17 lines, -22 lines 0 comments Download
M main/classes/core/src/com/ibm/icu/text/BreakIteratorFactory.java View 1 2 chunks +2 lines, -4 lines 0 comments Download
M main/classes/core/src/com/ibm/icu/text/DictionaryData.java View 1 2 chunks +2 lines, -4 lines 0 comments Download
M main/classes/core/src/com/ibm/icu/text/RBBIDataWrapper.java View 1 6 chunks +44 lines, -21 lines 0 comments Download
M main/classes/core/src/com/ibm/icu/text/RBBIRuleBuilder.java View 1 3 chunks +3 lines, -6 lines 0 comments Download
M main/classes/core/src/com/ibm/icu/text/RuleBasedBreakIterator.java View 1 3 chunks +3 lines, -3 lines 0 comments Download
M main/classes/core/src/com/ibm/icu/text/SpoofChecker.java View 1 4 chunks +24 lines, -18 lines 0 comments Download
M main/classes/core/src/com/ibm/icu/text/StringPrep.java View 1 3 chunks +7 lines, -11 lines 0 comments Download
M main/tests/charset/src/com/ibm/icu/dev/test/charset/TestConversion.java View 1 6 chunks +26 lines, -21 lines 0 comments Download

Messages

Total messages: 5
markus.icu
3 years, 1 month ago (2014-07-29 20:52:58 UTC) #1
roubert (google)
https://codereview.appspot.com/121870043/diff/1/main/classes/charset/src/com/ibm/icu/charset/CharsetCallback.java File main/classes/charset/src/com/ibm/icu/charset/CharsetCallback.java (right): https://codereview.appspot.com/121870043/diff/1/main/classes/charset/src/com/ibm/icu/charset/CharsetCallback.java#newcode3 main/classes/charset/src/com/ibm/icu/charset/CharsetCallback.java:3: * Copyright (C) 2006-2011, International Business Machines Corporation and ...
3 years, 1 month ago (2014-07-30 01:03:51 UTC) #2
markus.icu
code review changes r36102
3 years, 1 month ago (2014-07-30 20:43:10 UTC) #3
markus.icu
https://codereview.appspot.com/121870043/diff/1/main/classes/charset/src/com/ibm/icu/charset/CharsetCallback.java File main/classes/charset/src/com/ibm/icu/charset/CharsetCallback.java (right): https://codereview.appspot.com/121870043/diff/1/main/classes/charset/src/com/ibm/icu/charset/CharsetCallback.java#newcode3 main/classes/charset/src/com/ibm/icu/charset/CharsetCallback.java:3: * Copyright (C) 2006-2011, International Business Machines Corporation and ...
3 years, 1 month ago (2014-07-30 20:48:56 UTC) #4
roubert (google)
3 years, 1 month ago (2014-07-30 21:42:57 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted