cmd/jujud: use API-based upgrader

cmd/jujud: use API-based upgrader

This also has https://code.launchpad.net/~rogpeppe/juju-core/355-remove-1.10-hacks/+merge/177638
as another prerequisite which I can't add because of the only-one prereq rule
(hopefully that one will be approved and merged soon)

https://code.launchpad.net/~rogpeppe/juju-core/354-use-upgrader/+merge/177909

Requires: https://code.launchpad.net/~rogpeppe/juju-core/356-state-agent-entity/+merge/177892

(do not edit description out of merge proposal)

[dimitern, 2013-07-31 17:24:07]

Awesome! LGTM with one question

https://codereview.appspot.com/12183043/diff/1/cmd/jujud/machine.go
File cmd/jujud/machine.go (left):

https://codereview.appspot.com/12183043/diff/1/cmd/jujud/machine.go#oldcode89
cmd/jujud/machine.go:89: if err := EnsureWeHaveLXC(a.Conf.DataDir, a.Tag()); err
!= nil {
Why is this gone?

https://codereview.appspot.com/12183043/diff/1/cmd/jujud/upgrade.go
File cmd/jujud/upgrade.go (left):

https://codereview.appspot.com/12183043/diff/1/cmd/jujud/upgrade.go#oldcode1
cmd/jujud/upgrade.go:1: // Copyright 2012, 2013 Canonical Ltd.
yay!

[rog, 2013-08-01 15:56:58]

Please take a look.

[mue, 2013-08-01 16:05:58]

LGTM

[jameinel, 2013-08-08 16:03:50]

This looks pretty good overall, though I'd like a direct test that Unit Agents
can talk to the Upgrader API, like you did for the Agent API itself.

https://codereview.appspot.com/12183043/diff/4001/state/apiserver/agent/agent...
File state/apiserver/agent/agent_test.go (right):

https://codereview.appspot.com/12183043/diff/4001/state/apiserver/agent/agent...
state/apiserver/agent/agent_test.go:73: 
This is the "positive assertion" test I mention in the other code. You have this
for agent.API but not for upgrader.

https://codereview.appspot.com/12183043/diff/4001/state/apiserver/upgrader/up...
File state/apiserver/upgrader/upgrader.go (right):

https://codereview.appspot.com/12183043/diff/4001/state/apiserver/upgrader/up...
state/apiserver/upgrader/upgrader.go:31: if !authorizer.AuthMachineAgent() &&
!authorizer.AuthUnitAgent() {
This change is a correct one, but you are missing the matching test case that
asserts that when you aren't a Machine agent but you are a Unit Agent it allows
you to connect to the Upgrader api.

Can you add this in a follow up branch?