Fix issue 1211: xmlns declarations on HTML elements in HTML parsing mode.

http://code.google.com/p/google-caja/issues/detail?id=1211

This fixes the way we sneak XML attributes through the HTML tree builder
so that it doesn't trigger error conditions in xerces's DOM implementation
but still lets us determine the proper namespace for an element after
the tree builder has figured out where elements begin and end.


Submitted @4098

[MikeSamuel, 2010-05-21 21:30:07]

This was missing a file.  Added and snapshotted.

2010/5/21  <mikesamuel@gmail.com>:
> Reviewers: jasvir,
>
> Description:
> http://code.google.com/p/google-caja/issues/detail?id=1211
>
> This fixes the way we sneak XML attributes through the HTML tree builder
> so that it doesn't trigger error conditions in xerces's DOM
> implementation
> but still lets us determine the proper namespace for an element after
> the tree builder has figured out where elements begin and end.
>
> Please review this at http://codereview.appspot.com/1218046/show
>
> Affected files:
>  M     src/com/google/caja/parser/html/CajaTreeBuilder.java
>  M     src/com/google/caja/parser/html/DomParser.java
>  M     src/com/google/caja/parser/html/Html5ElementStack.java
>  M     tests/com/google/caja/parser/html/DomParserTest.java
>
>
>

[MikeSamuel, 2010-05-26 18:29:28]

ping

[Jasvir, 2010-05-27 16:48:04]

LGTM

http://codereview.appspot.com/1218046/diff/7001/8002
File src/com/google/caja/parser/html/AttributeNameFixup.java (right):

http://codereview.appspot.com/1218046/diff/7001/8002#newcode51
src/com/google/caja/parser/html/AttributeNameFixup.java:51: static final String
PREFIX = "f:";
What happens if the input itself uses the f: prefix?

[MikeSamuel, 2010-06-01 22:02:04]

http://codereview.appspot.com/1218046/diff/7001/8002
File src/com/google/caja/parser/html/AttributeNameFixup.java (right):

http://codereview.appspot.com/1218046/diff/7001/8002#newcode51
src/com/google/caja/parser/html/AttributeNameFixup.java:51: static final String
PREFIX = "f:";
On 2010/05/27 16:48:05, jasvir wrote:
> What happens if the input itself uses the f: prefix?

I added a test to check that.  See other comment for a pointer.

http://codereview.appspot.com/1218046/diff/12001/13001
File tests/com/google/caja/parser/html/DomParserTest.java (right):

http://codereview.appspot.com/1218046/diff/12001/13001#newcode2462
tests/com/google/caja/parser/html/DomParserTest.java:2462: + "  <f:foo
bar=\"baz\" f:boo=\"far\"/>\n"
This is the test I added.