Issue 12178043: Integrate the MinUnits worker.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12178043: Integrate the MinUnits worker.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by frankban

Modified:
10 years, 9 months ago

Reviewers:
dimitern, mp+177903, wallyworld

Visibility:
Public.

Description

Integrate the MinUnits worker. Added the MinUnitsWorker to the ManageState job. Added a test to ensure the worker is started. https://code.launchpad.net/~frankban/juju-core/minunits-integrate-worker/+merge/177903 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -0 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujud/machine.go	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	cmd/jujud/machine_test.go	View	1 chunk	+33 lines, -0 lines	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dimitern

LGTM with a suggestion https://codereview.appspot.com/12178043/diff/1/cmd/jujud/machine_test.go File cmd/jujud/machine_test.go (right): https://codereview.appspot.com/12178043/diff/1/cmd/jujud/machine_test.go#newcode446 cmd/jujud/machine_test.go:446: if len(units) == 1 { ...

10 years, 9 months ago (2013-08-02 09:37:14 UTC) #3

Merged. Thank you both for the reviews!

Expand All Messages | Collapse All Messages