src/pkg/reflect/asm_amd64.s - Issue 12163043: code review 12163043: cmd/gc: record argument size for all indirect function calls

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: src/pkg/reflect/asm_amd64.s

Issue 12163043: code review 12163043: cmd/gc: record argument size for all indirect function calls (Closed)

Patch Set: diff -r 475e11851fc1 https://dvyukov%40google.com@code.google.com/p/go/ Created 11 years, 8 months ago

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2012 The Go Authors. All rights reserved.	1 // Copyright 2012 The Go Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style	2 // Use of this source code is governed by a BSD-style

3 // license that can be found in the LICENSE file.	3 // license that can be found in the LICENSE file.

4	4

5 // makeFuncStub is the code half of the function returned by MakeFunc.	5 // makeFuncStub is the code half of the function returned by MakeFunc.

6 // See the comment on the declaration of makeFuncStub in makefunc.go	6 // See the comment on the declaration of makeFuncStub in makefunc.go

7 // for more details.	7 // for more details.

	8 // No argsize here, gc generates argsize info at call site.

8 TEXT ·makeFuncStub(SB),7,$16	9 TEXT ·makeFuncStub(SB),7,$16

9 MOVQ DX, 0(SP)	10 MOVQ DX, 0(SP)

10 LEAQ argframe+0(FP), CX	11 LEAQ argframe+0(FP), CX

11 MOVQ CX, 8(SP)	12 MOVQ CX, 8(SP)

12 CALL ·callReflect(SB)	13 CALL ·callReflect(SB)

13 RET	14 RET

14	15

15 // methodValueCall is the code half of the function returned by makeMethodValue.	16 // methodValueCall is the code half of the function returned by makeMethodValue.

16 // See the comment on the declaration of methodValueCall in makefunc.go	17 // See the comment on the declaration of methodValueCall in makefunc.go

17 // for more details.	18 // for more details.

	19 // No argsize here, gc generates argsize info at call site.

18 TEXT ·methodValueCall(SB),7,$16	20 TEXT ·methodValueCall(SB),7,$16

19 MOVQ DX, 0(SP)	21 MOVQ DX, 0(SP)

20 LEAQ argframe+0(FP), CX	22 LEAQ argframe+0(FP), CX

21 MOVQ CX, 8(SP)	23 MOVQ CX, 8(SP)

22 CALL ·callMethod(SB)	24 CALL ·callMethod(SB)

23 RET	25 RET

OLD	NEW

« no previous file with comments | « src/pkg/reflect/asm_386.s ('k') | src/pkg/reflect/asm_arm.s » ('j') | no next file with comments »