Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(53)

Issue 12159043: Add skia to list of valid trackers

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by rmistry
Modified:
12 years, 5 months ago
Reviewers:
iannucci
CC:
skiabot_google.com
Visibility:
Public.

Description

Add skia to list of valid trackers. Created to fix bug https://code.google.com/p/skia/issues/detail?id=1453 : bug=xxx points to Chromium instead of Skia. Change staged here: https://skia-codereview-staging.appspot.com/10001/

Patch Set 1 #

Total comments: 2

Patch Set 2 : Making line < 80 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M codereview/views.py View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6
rmistry
12 years, 5 months ago (2013-07-31 12:36:24 UTC) #1
iannucci
lgtm https://codereview.appspot.com/12159043/diff/1/codereview/views.py File codereview/views.py (right): https://codereview.appspot.com/12159043/diff/1/codereview/views.py#newcode2178 codereview/views.py:2178: valid_trackers = ('chromium', 'chromium-os', 'chrome-os-partner', 'gyp', 'skia', 80 ...
12 years, 5 months ago (2013-07-31 18:26:05 UTC) #2
rmistry
https://codereview.appspot.com/12159043/diff/1/codereview/views.py File codereview/views.py (right): https://codereview.appspot.com/12159043/diff/1/codereview/views.py#newcode2178 codereview/views.py:2178: valid_trackers = ('chromium', 'chromium-os', 'chrome-os-partner', 'gyp', 'skia', On 2013/07/31 ...
12 years, 5 months ago (2013-08-01 11:12:28 UTC) #3
rmistry
On 2013/08/01 11:12:28, rmistry wrote: > https://codereview.appspot.com/12159043/diff/1/codereview/views.py > File codereview/views.py (right): > > https://codereview.appspot.com/12159043/diff/1/codereview/views.py#newcode2178 > ...
12 years, 5 months ago (2013-08-01 11:21:24 UTC) #4
iannucci
On 2013/08/01 11:21:24, rmistry wrote: > On 2013/08/01 11:12:28, rmistry wrote: > > https://codereview.appspot.com/12159043/diff/1/codereview/views.py > ...
12 years, 5 months ago (2013-08-01 18:03:30 UTC) #5
rmistry
12 years, 5 months ago (2013-08-01 18:08:36 UTC) #6
On 2013/08/01 18:03:30, iannucci wrote:
> On 2013/08/01 11:21:24, rmistry wrote:
> > On 2013/08/01 11:12:28, rmistry wrote:
> > > https://codereview.appspot.com/12159043/diff/1/codereview/views.py
> > > File codereview/views.py (right):
> > > 
> > >
> https://codereview.appspot.com/12159043/diff/1/codereview/views.py#newcode2178
> > > codereview/views.py:2178: valid_trackers = ('chromium', 'chromium-os',
> > > 'chrome-os-partner', 'gyp', 'skia',
> > > On 2013/07/31 18:26:05, iannucci wrote:
> > > > 80 columns? Or is the diff view being silly?
> > > 
> > > Fixed. I had my column width set to 100 and thus did not notice.
> > 
> > Submitted and pushed to production. Made it the default version since it was
> the
> > only CL submitting after the version that was live.
> 
> Cool :)
> 
> In The Future, we should (all, myself included) get in the habit of sending a
> note to chrome-infrastructure-team@ when we roll rietveld on
chromiumcodereview.
> I know we have been inconsistent about this in the past, but we should
converge
> towards that. It would also be useful to provide any special rollback
> instructions in case of datastore changes, etc :)

SGTM. I joined chrome-infrastructure-team@ a few mins ago.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b