Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3131)

Issue 12132043: Fix a C++11 error.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by thakis
Modified:
11 years, 5 months ago
Reviewers:
alkondratenko
CC:
google-perftools_googlegroups.com
Base URL:
http://gperftools.googlecode.com/svn/trunk/src/
Visibility:
Public.

Description

Fix a C++11 error. New clang versions complain in C++11 mode that: error: cannot initialize a variable of type 'void *' with an rvalue of type 'uintptr_t' (aka 'unsigned long') This same change was done for the google-internal version of tcmalloc, and for the copy in Chromium. This upstreams http://crrev.com/209312

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M stack_trace_table.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
thakis
(Should I cc google-perftools on reviews?)
11 years, 5 months ago (2013-07-30 22:10:58 UTC) #1
alkondratenko
Regarding cc-ing mailing list I think that's fine, but I'm not seeing any mail in ...
11 years, 5 months ago (2013-07-31 03:42:41 UTC) #2
thakis
On Tue, Jul 30, 2013 at 8:42 PM, <alkondratenko@gmail.com> wrote: > Regarding cc-ing mailing list ...
11 years, 5 months ago (2013-07-31 03:56:34 UTC) #3
alkondratenko
11 years, 5 months ago (2013-07-31 04:02:58 UTC) #4
On Wed, Jul 31, 2013 at 6:56 AM, Nico Weber <thakis@chromium.org> wrote:

> On Tue, Jul 30, 2013 at 8:42 PM, <alkondratenko@gmail.com> wrote:
>
>> Regarding cc-ing mailing list I think that's fine, but I'm not seeing
>> any mail in the group.
>>
>
> Maybe I need to be subscribed to be able to post? (which I'm not)
>

Possibly. I'm not expert.


>
>
>>
>> Patch itself trivially correct (as I'm pretty sure chromium review
>> already said).
>>
>
> Thanks! Can you land this then?
>

Just did. Thanks.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b