Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2376)

Issue 12114043: cmd/jujud: remove compatibility hacks

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by rog
Modified:
10 years, 9 months ago
Reviewers:
mue, mp+177638, fwereade, thumper
Visibility:
Public.

Description

cmd/jujud: remove compatibility hacks After some discussion with fwereade, we've decided that these are unnecessary (and broken too - EnsureAPIInfo only works pretty much by coincidence, and won't work when the unit agent is connecting to the API). If anyone is still running 1.10, they can still upgrade, but they'll need to do it by upgrading via 1.12. https://code.launchpad.net/~rogpeppe/juju-core/355-remove-1.10-hacks/+merge/177638 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cmd/jujud: remove compatibility hacks #

Patch Set 3 : cmd/jujud: remove compatibility hacks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -532 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/jujud/machine.go View 1 2 2 chunks +0 lines, -9 lines 0 comments Download
M cmd/jujud/unit.go View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D cmd/jujud/upgradevalidation.go View 1 2 1 chunk +0 lines, -182 lines 0 comments Download
D cmd/jujud/upgradevalidation_test.go View 1 chunk +0 lines, -336 lines 0 comments Download

Messages

Total messages: 5
rog
Please take a look.
10 years, 9 months ago (2013-07-30 16:03:22 UTC) #1
fwereade
LGTM. Would appreciate if you ran it past thumper too, just in case there's some ...
10 years, 9 months ago (2013-07-30 16:20:17 UTC) #2
mue
LGTM
10 years, 9 months ago (2013-07-30 16:22:12 UTC) #3
thumper
On 2013/07/30 16:20:17, fwereade wrote: > LGTM. Would appreciate if you ran it past thumper ...
10 years, 9 months ago (2013-07-31 22:02:10 UTC) #4
rog
10 years, 9 months ago (2013-08-01 15:07:47 UTC) #5
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b