Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2206)

Issue 121061: Fix for issue https://bugs.tryton.org/roundup/issue1186 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by bch
Modified:
11 years, 9 months ago
Reviewers:
yangoon1, ced1
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : ignore non-active prod in product_by_location + handle modified prod when completing inventory #

Total comments: 2

Patch Set 3 : Join only if needed #

Total comments: 3

Patch Set 4 : Guidelines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -10 lines) Patch
M inventory.py View 1 chunk +4 lines, -0 lines 0 comments Download
M product.py View 1 2 3 5 chunks +23 lines, -10 lines 0 comments Download

Messages

Total messages: 12
bch
11 years, 9 months ago (2009-09-22 07:53:09 UTC) #1
ced1
Looks good for me
11 years, 9 months ago (2009-09-22 07:56:11 UTC) #2
yangoon1
11 years, 9 months ago (2009-09-22 09:06:17 UTC) #3
bch
11 years, 9 months ago (2009-09-23 12:44:05 UTC) #4
ced1
http://codereview.appspot.com/121061/diff/2001/3002 File product.py (right): http://codereview.appspot.com/121061/diff/2001/3002#newcode378 Line 378: where_clause += "AND product_template.active = 't'" You must ...
11 years, 9 months ago (2009-09-23 12:50:24 UTC) #5
bch
11 years, 9 months ago (2009-09-23 13:48:15 UTC) #6
ced1
http://codereview.appspot.com/121061/diff/3006/3008 File product.py (right): http://codereview.appspot.com/121061/diff/3006/3008#newcode377 Line 377: product_template_join = "" I find it is better ...
11 years, 9 months ago (2009-09-23 13:52:35 UTC) #7
bch
http://codereview.appspot.com/121061/diff/3006/3008 File product.py (right): http://codereview.appspot.com/121061/diff/3006/3008#newcode377 Line 377: product_template_join = "" On 2009/09/23 13:52:35, ced wrote: ...
11 years, 9 months ago (2009-09-23 14:19:51 UTC) #8
ced1
http://codereview.appspot.com/121061/diff/3006/3008 File product.py (right): http://codereview.appspot.com/121061/diff/3006/3008#newcode377 Line 377: product_template_join = "" On 2009/09/23 14:19:51, bch wrote: ...
11 years, 9 months ago (2009-09-23 14:22:41 UTC) #9
bch
11 years, 9 months ago (2009-09-23 14:26:26 UTC) #10
ced1
Ok for me
11 years, 9 months ago (2009-09-23 14:31:27 UTC) #11
ced1
11 years, 9 months ago (2009-09-28 09:27:40 UTC) #12
Can be closed
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b