Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(43)

Issue 121059: Issue 1110: Exception var in remote script conflicts with page global var, preventing cajole (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 8 months ago by MikeSamuel
Modified:
16 years, 8 months ago
Reviewers:
ihab.awad
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

http://code.google.com/p/google-caja/issues/detail?id=1110 file x.js (function () { try {} catch (x) {} })(); page.html <!doctype html><head></head><body> <script src="x.js"></script> <script>var x = 'boom';</script> </body></html> This generates the following error from cajole_html: [exec] ERROR: x.js:2+19 - 20: Declaration of x masks declaration at basic.html:10+5 - 6 There is no error for <script>(function () { var x = 'boom'; })();</script> Changed Scope to not prevent exception/var masking across function scope boundaries.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -26 lines) Patch
M src/com/google/caja/parser/quasiliteral/Scope.java View 1 chunk +25 lines, -26 lines 0 comments Download
M tests/com/google/caja/parser/quasiliteral/ScopeTest.java View 2 chunks +45 lines, -0 lines 0 comments Download

Messages

Total messages: 2
MikeSamuel
16 years, 8 months ago (2009-09-22 03:05:34 UTC) #1
MikeSamuel
16 years, 8 months ago (2009-09-28 19:38:11 UTC) #2
Please don't review.  This change introduces more problems than it fixes.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b