Issue 121057: Some cleanup of various things.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 121057: Some cleanup of various things. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 8 months ago by MikeSamuel

Modified:
16 years, 8 months ago

Reviewers:
metaweta

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Various unrelated fixes. - Added toString to CharProducer to fix confusion that toString() does something very different from toString(int, int) - Fixed comments. - Changed CssTree to pad spaces around the body of subst productions. - Changed ParseTreeNodes to reuse the parameterTypes variable instead of constructing two arrays of classes. - Changed CssValidator to recognize suffixless substs as lengths. This does not affect the rewriting of "width: 3" to "width: 3px". - Changed build.xml to delete the ant-maven directory on "ant clean" instead of recreating it. Submitted @3740

Patch Set 1 #

Created: 16 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -9 lines)			Patch
M	build.xml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/com/google/caja/lexer/CharProducer.java	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/com/google/caja/lexer/CssLexer.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/com/google/caja/parser/ParseTreeNodes.java	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/com/google/caja/parser/css/CssTree.java	View	2 chunks	+8 lines, -2 lines	0 comments	Download
M	src/com/google/caja/plugin/CssValidator.java	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

On 2009/09/22 00:07:56, MikeSamuel wrote:
> 

LGTM

Expand All Messages | Collapse All Messages