Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(129)

Issue 121045: QuasiLiterals for HTML (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 8 months ago by MikeSamuel
Modified:
16 years, 8 months ago
Reviewers:
Jasvir
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

To generate IHTML templates from another templating language, I find myself needing HTML quasiliterals. I pulled this out of the jsdoc code, and added stuff to infer file positions for the quasi nodes by looking at the nodes with positions that are sprinkled throughout. Also fixd a few jsdoc warnings. Submitted @3733

Patch Set 1 #

Patch Set 2 : QuasiLiterals for HTML #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1361 lines, -12 lines) Patch
M src/com/google/caja/lang/html/HTML.java View 1 chunk +1 line, -1 line 0 comments Download
A src/com/google/caja/lexer/PositionInferer.java View 1 1 chunk +401 lines, -0 lines 0 comments Download
A src/com/google/caja/parser/html/HtmlQuasiBuilder.java View 1 chunk +407 lines, -0 lines 0 comments Download
M src/com/google/caja/parser/quasiliteral/AlphaRenaming.java View 1 chunk +1 line, -1 line 0 comments Download
M src/com/google/caja/tools/TransformAntTask.java View 1 chunk +4 lines, -2 lines 0 comments Download
M src/com/google/caja/util/HandledAppendable.java View 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/AllTests.java View 4 chunks +4 lines, -0 lines 0 comments Download
M tests/com/google/caja/lexer/FilePositionTest.java View 1 chunk +10 lines, -0 lines 0 comments Download
A tests/com/google/caja/lexer/PositionInfererTest.java View 1 chunk +263 lines, -0 lines 0 comments Download
A tests/com/google/caja/parser/html/HtmlQuasiBuilderTest.java View 1 chunk +264 lines, -0 lines 0 comments Download
M tests/com/google/caja/parser/quasiliteral/CommonJsRewriterTestCase.java View 4 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 2
MikeSamuel
16 years, 8 months ago (2009-09-18 19:10:42 UTC) #1
Jasvir
16 years, 8 months ago (2009-09-21 23:08:23 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b