Issue 12088045: Missing FLAGS from old_run.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12088045: Missing FLAGS from old_run. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by jcgregorio_google

Modified:
11 years, 11 months ago

Reviewers:
dhermes

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

More Reviews

Patch Set 1 #

Total comments: 2

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	oauth2client/tools.py	View		1 chunk	+1 line, -0 lines	2 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dhermes

https://codereview.appspot.com/12088045/diff/1/oauth2client/tools.py File oauth2client/tools.py (right): https://codereview.appspot.com/12088045/diff/1/oauth2client/tools.py#newcode237 oauth2client/tools.py:237: from old_run import FLAGS This is needed for people ...

11 years, 11 months ago (2013-07-30 17:11:30 UTC) #2

jcgregorio_google

11 years, 11 months ago (2013-07-30 17:16:23 UTC) #3

jcgregorio_google

11 years, 11 months ago (2013-07-30 17:24:13 UTC) #5

On 2013/07/30 17:16:44, dhermes wrote:
> LGTM

Committed in
https://code.google.com/p/google-api-python-client/source/detail?r=1c0079a002...

Expand All Messages | Collapse All Messages